override healthcheck in dockerfile#946
Conversation
Signed-off-by: Areeb Ahmed <areebahmed0709@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request exposes the model runner port and adds a healthcheck command to the Dockerfile. However, a critical issue was identified where the healthcheck will fail in the final-llamacpp image variant because curl is not installed, which would mark the container as permanently unhealthy. To resolve this, curl must be installed in the llamacpp stage.
| HEALTHCHECK --interval=30s --timeout=10s --start-period=10s --retries=3 \ | ||
| CMD curl -f "http://localhost:${MODEL_RUNNER_PORT}/engines/status" || exit 1 |
There was a problem hiding this comment.
The final-llamacpp image variant does not have curl installed, which causes this healthcheck to fail with a command-not-found error, marking the container as permanently unhealthy. Since the vllm and sglang stages explicitly install curl, it is not present in the base llamacpp image. To resolve this, curl must be installed in the llamacpp stage (for example, by adding it to scripts/apt-install.sh).
There was a problem hiding this comment.
not valid. curl is present.
1 participant
inherit the correct port and /engines/status endpoint for all image variants
fixes #942