Add post-installation config section for ML-KEM KRA - #5412
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe KRA installation guide adds ML-KEM configuration references and post-installation instructions. The instructions cover archival encryption limits, AES-256-KWP PKCS#12 settings, and required KRA instance restarts. ChangesKRA ML-KEM guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/installation/kra/installing-kra-with-pqc.adoc (1)
125-130: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winDocument active ML-KEM wrapping selection.
wrapping.2inCS.cfgis inactive unlesskra.storageUnit.wrapping.choice=2is set. The deployed KRA useschoice=2, and the shared template still containschoice=1; say thatpkispawnsetschoice=2for PQC KRA installs so this section is clear.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/installation/kra/installing-kra-with-pqc.adoc` around lines 125 - 130, Update the ML-KEM KRA installation documentation near the wrapping.2 configuration description to state that pkispawn sets kra.storageUnit.wrapping.choice=2 for PQC KRA installations, activating wrapping.2. Clarify that the shared template may still contain choice=1.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/installation/kra/installing-kra-with-pqc.adoc`:
- Around line 125-130: Update the ML-KEM KRA installation documentation near the
wrapping.2 configuration description to state that pkispawn sets
kra.storageUnit.wrapping.choice=2 for PQC KRA installations, activating
wrapping.2. Clarify that the shared template may still contain choice=1.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e38cafeb-03c2-47ba-91f7-117da7ae79f5
📒 Files selected for processing (1)
docs/installation/kra/installing-kra-with-pqc.adoc
fmarco76
left a comment
There was a problem hiding this comment.
LGTM. I have a comment for the latest command but feel free to update/merge.
|
|
||
| [literal] | ||
| .... | ||
| $ systemctl restart pki-tomcatd@pki-tomcat |
There was a problem hiding this comment.
Instance name could be different from pki-tomcat. Should this be:
$ systemctl restart pki-tomcatd@<pki_instance_name>.service
Alternatively, we have internal command:
pki-server restart [OPTIONS] [<instance ID>]
If instance is not provided default is used.
- Document ML-KEM wrapping.2 configuration differences - Add recommended security settings (AES-KWP for PKCS#12) - Note that ML-KEM doesn't support kra.allowEncDecrypt.archival IDM-6732
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Thanks @fmarco76 ! |
Summary by CodeRabbit