Skip to content

KRATool: Update error message to include keysize 168 - #5415

Merged
ladycfu merged 1 commit into
dogtagpki:v10.13from
ladycfu:kratool-cross-scheme-fixes.v10.13.13-part2
Aug 4, 2026
Merged

KRATool: Update error message to include keysize 168#5415
ladycfu merged 1 commit into
dogtagpki:v10.13from
ladycfu:kratool-cross-scheme-fixes.v10.13.13-part2

Conversation

@ladycfu

@ladycfu ladycfu commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Updates the error message for source payload wrapping key size validation to accurately reflect that 168 is an accepted value (for DES3/DESede only). The error message now lists all valid values (128, 168, 192, 256) with a note explaining that 168 is DES3-specific and 192 is recommended for better PKCS#11 compatibility.

This addresses reviewer feedback that the previous error message was misleading when operators entered a valid DES3 keysize of 168.

Assisted-by: Claude
DOGTAG-4555

Updates the error message for source payload wrapping key size validation
to accurately reflect that 168 is an accepted value (for DES3/DESede only).
The error message now lists all valid values (128, 168, 192, 256) with a
note explaining that 168 is DES3-specific and 192 is recommended for better
PKCS#11 compatibility.

This addresses reviewer feedback that the previous error message was
misleading when operators entered a valid DES3 keysize of 168.

Assisted-by: Claude
DOGTAG-4555
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c3683e97-a0f4-4bfd-8964-cf6a4496401c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ladycfu

ladycfu commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

This "part 2" PR has been pre-approved by @jmagne

@ladycfu
ladycfu merged commit 1dd8478 into dogtagpki:v10.13 Aug 4, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant