[auto-bump] [no-release-notes] dependency by coffeegoddd#2752
[auto-bump] [no-release-notes] dependency by coffeegoddd#2752coffeegoddd wants to merge 1 commit into
Conversation
|
Ito Test Report ✅6 test cases ran. 1 additional finding, 5 passed. Overall, the unified run passed 5 of 6 test cases, confirming stable multi-row and mixed-statement query behavior, successful standard startup to ReadyForQuery, and consistent boolean staged semantics in dolt.status across repeated and expanded reads, while two additional executions had no includable pass/fail outcomes. The only failure was a minor startup-protocol defect where malformed SSL/GSS message ordering is rejected by disconnecting without sending an explicit protocol ErrorResponse first, reducing diagnostic clarity even though clean reconnects and normal availability remain unaffected. ✅ Passed (5)ℹ️ Additional Findings (1)
🟡 Missing explicit startup protocol error response
Relevant code:
case *pgproto3.SSLRequest:
hasCertificate := len(certificate.Certificate) > 0
var performSSL = []byte("N")
if hasCertificate {
performSSL = []byte("S")
}
_, err = h.Conn().Write(performSSL)
if err != nil {
return false, errors.Errorf("error sending SSL request: %w", err)
}
return h.handleStartup()
case *pgproto3.GSSEncRequest:
_, err = h.Conn().Write([]byte("N"))
if err != nil {
return false, errors.Errorf("error sending response to GSS Enc Request: %w", err)
}
return h.handleStartup()
default:
return false, errors.Errorf("terminating connection: unexpected start message: %#v", startupMessage)
if proceed, err := h.handleStartup(); err != nil || !proceed {
returnErr = err
return
}
func (h *ConnectionHandler) sendError(err error) {
fmt.Println(err.Error())
if sendErr := h.send(&pgproto3.ErrorResponse{
Severity: string(ErrorResponseSeverity_Error),
Code: "XX000", // internal_error for now
Message: err.Error(),
}); sendErr != nil {Commit: Tell us how we did: Give Ito Feedback |
|






☕ An Automated Dependency Version Bump PR 👑
Initial Changes
The changes contained in this PR were produced by `go get`ing the dependency.
```bash
go get github.com/dolthub/[dependency]/go@[commit]
```