Attach DebuggableAttribute to FSI multi-emit manifests under --debug+#19921
Open
T-Gro wants to merge 4 commits into
Open
Attach DebuggableAttribute to FSI multi-emit manifests under --debug+#19921T-Gro wants to merge 4 commits into
T-Gro wants to merge 4 commits into
Conversation
…buggableAttribute (#14572) Phase 1 (RED) of TDD for issue #14572. Adds four xUnit Facts under Scripting.MultiEmit.DebuggableAttributeManifest that reflect on Assembly.GetExecutingAssembly() inside an FSI submission to inspect the manifest-level DebuggableAttribute that the multi-emit code path is expected to attach when --debug+ is in effect. On current main: * multi-emit submission with --debug+ has DebuggableAttribute with DisableOptimizations -> FAILS (manifest has no DebuggableAttribute) * multi-emit submission with --debug- has no DebuggableAttribute -> passes (negative control) * single-emit submission with --debug+ keeps DebuggableAttribute (regression) -> passes (uses --optimize- to exercise the ilreflect.fs codepath that gates on optimize=false) * multi-emit + --debug+ does not duplicate user-declared DebuggableAttribute -> FAILS (no attribute attached at all yet) The production fix lives in a separate sprint; no source files under src/ are touched here. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…#14572) When FSI is configured for multi-assembly emit (--multiemit+) the per-submission dynamic assembly's manifest now carries System.Diagnostics.DebuggableAttribute with DisableOptimizations|Default whenever --debug is enabled, matching the single-emit path (ilreflect.fs) and the regular compiler (CreateILModule.fs). Dedups against a user-declared assembly DebuggableAttribute. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14572
--multiemit+submissions now getDebuggableAttribute(DisableOptimizations|Default)ontheir manifest when
--debug+is set, matching single-emit and batch-compiler behavior.