Fix client_init() assert#116
Open
slusarz wants to merge 3 commits intodovecot:mainfrom
Open
Conversation
If a stalled client's index is reassigned to a new connection before the stalled client is restarted, client_init() would trigger an assertion failure. Fixes triggering assertion: Panic: file client.c: line 252 (client_init): assertion failed: (idx >= array_count(&clients) || *(struct client **)array_idx(&clients, idx) == NULL)
sirainen
reviewed
Apr 24, 2026
Contributor
sirainen
left a comment
sirainen
left a comment
There was a problem hiding this comment.
Whoa, the first unit test, crazy stuff.
| int fd; | ||
|
|
||
| if (idx < array_count(&clients) && | ||
| *(struct client *const *)array_idx(&clients, idx) != NULL) { |
Contributor
There was a problem hiding this comment.
I think array_idx_elem() != NULL to avoid *(struct client *const *)
slusarz
force-pushed
the
client_init_assert_fix
branch
from
42bdeff to
c6dd6af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.