chore: change request log level in proxy#1710
Closed
CooooolFrog wants to merge 0 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
- Coverage 50.29% 50.26% -0.04%
==========================================
Files 86 86
Lines 21952 21952
==========================================
- Hits 11041 11034 -7
- Misses 10911 10918 +7
🚀 New features to boost your workflow:
|
gaius-qi
requested changes
Mar 10, 2026
Author
This is better. I'll modify it again: output the part of the request excluding the header at the Info level, and output the header separately at the debug level. |
Author
|
I misused git force push, which closed this PR. Please continue reviewing in this new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a potential security problem mentioned in this issue (#1559) by changing the output logs for request-related data from the info level to the debug level, thus preventing the direct output of sensitive information.
Related Issue
#1559