Skip to content

chore: change request log level in proxy#1710

Closed
CooooolFrog wants to merge 0 commit into
dragonflyoss:mainfrom
CooooolFrog:main
Closed

chore: change request log level in proxy#1710
CooooolFrog wants to merge 0 commit into
dragonflyoss:mainfrom
CooooolFrog:main

Conversation

@CooooolFrog
Copy link
Copy Markdown

Description

This PR addresses a potential security problem mentioned in this issue (#1559) by changing the output logs for request-related data from the info level to the debug level, thus preventing the direct output of sensitive information.

Related Issue

#1559

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.26%. Comparing base (c70d810) to head (42a2902).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1710      +/-   ##
==========================================
- Coverage   50.29%   50.26%   -0.04%     
==========================================
  Files          86       86              
  Lines       21952    21952              
==========================================
- Hits        11041    11034       -7     
- Misses      10911    10918       +7     
Files with missing lines Coverage Δ
dragonfly-client/src/proxy/mod.rs 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the key download information should be kept, but we can remove the request headers when printing. The log output level still needs to be set to INFO.

@CooooolFrog
Copy link
Copy Markdown
Author

I think the key download information should be kept, but we can remove the request headers when printing. The log output level still needs to be set to INFO.

This is better. I'll modify it again: output the part of the request excluding the header at the Info level, and output the header separately at the debug level.

@CooooolFrog
Copy link
Copy Markdown
Author

I misused git force push, which closed this PR. Please continue reviewing in this new PR.
#1715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants