Skip to content

Adjust license to reflect a MIT-only source, and add a MIT license file#218

Merged
danielrh merged 1 commit into
dropbox:masterfrom
musicinmybrain:license-accuracy
Sep 22, 2024
Merged

Adjust license to reflect a MIT-only source, and add a MIT license file#218
danielrh merged 1 commit into
dropbox:masterfrom
musicinmybrain:license-accuracy

Conversation

@musicinmybrain

Copy link
Copy Markdown
Contributor

Since entropy_encode.rs appears to be derived from https://github.com/google/brotli/blob/v1.1.0/c/enc/entropy_encode.c (possibly at a different version), and carries only MIT terms, it’s not possible for the crate to be BSD-3-Clause OR MIT overall. The new LICENSE.MIT file is taken from
https://github.com/google/brotli/raw/refs/tags/v1.1.0/LICENSE since that appears to be the correct license text for entropy_encode.rs.

Fixes #41.

It would be great to have some kind of resolution to these licensing issues.

Since `entropy_encode.rs` appears to be derived from
https://github.com/google/brotli/blob/v1.1.0/c/enc/entropy_encode.c
(possibly at a different version), and carries only MIT terms, it’s not
possible for the crate to be `BSD-3-Clause OR MIT` overall. The new
`LICENSE.MIT` file is taken from
https://github.com/google/brotli/raw/refs/tags/v1.1.0/LICENSE since that
appears to be the correct license text for `entropy_encode.rs`.

Fixes dropbox#41.

Signed-off-by: Benjamin A. Beasley <code@musicinmybrain.net>
@musicinmybrain

Copy link
Copy Markdown
Contributor Author

The corresponding PR for rust-brotli-decompressor is dropbox/rust-brotli-decompressor#32.

@danielrh danielrh merged commit f41a059 into dropbox:master Sep 22, 2024
@nyurik

nyurik commented Sep 22, 2024

Copy link
Copy Markdown
Contributor

Shouldn't there be another line copyrighting @danielrh and possibly myself (lots of rewrites thereafter) as part of the MIT work?

@musicinmybrain

Copy link
Copy Markdown
Contributor Author

I don’t personally have enough insight into the development of this project to know who did what and under what terms, but you should certainly use your knowledge of that history to try to make this more accurate. Speaking as not-a-legal-expert, I don’t see any reason not to add additional copyright statements to the MIT license file, as long as you preserve the original one. I’ve seen that done pretty often. I guess you could also choose to have your own separate MIT license text in one file, and maintain a second MIT license file to cover code derived from https://github.com/google/brotli/.

In any case, whatever you end up deciding to do here, you should probably do the same thing in https://github.com/dropbox/rust-brotli-decompressor.

Thanks for following up on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BSD or MIT

3 participants