Adapt for GNOME 50#302
Open
ulugbekeshnazarov42 wants to merge 3 commits into
Open
Conversation
Owner
|
@ulugbekeshnazarov42, thank you so much for the pull request! I looked it over and it looks good, and I could merge everything except the two things on which I commented: the change to manager.js and the version number in metadata.json. Could you fix up those things? Great to have a new contributor, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the extension for GNOME 50 compatibility.
Changes:
global.screenfallbacks and useglobal.workspace_manager/global.display.global.screen_heightwithglobal.stage.height.Tested:
make schemapasses.git diff --checkpasses.Note:
make buildcould not be completed locally becausemsgfmtwas missing from the system.