chore: support Node 18 (matches Node-RED 4.x minimum)#17
Merged
Conversation
Lower engines.node from >=20 to >=18.5, the documented minimum of the latest Node-RED release. Add Node 18 to the CI matrix so the claim is actually tested instead of asserted. Note: Node 18 reached upstream EOL on 2025-04-30, so users on 18 won't get security patches from Node — but Node-RED itself still supports it, and the contrib-node packaging spec asks us to satisfy Node-RED's minimum, not our preference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
engines.nodelowered from>=20→>=18.5, matching the Node-RED 4.x minimum and the contrib-node packaging spec recommendation:ci.ymltest matrix gains18so the claim is verified, not asserted.Caveats
What was checked locally
jsonata@^2.0.5declaresengines.node >= 8— fine on 18node-red-node-test-helper@^0.3.6declaresengines.node >= 14— fine on 18structuredClonecallers, noArray.findLast, no top-level await, no native fetch in the runtime,node:fs/node:os/node:pathprefixes are 16+Test plan