Skip to content

[dataSourceNetboxVlans] - Add netbox_vlan.id in netbox_vlans.vlans DataSources#662

Merged
fbreckle merged 6 commits intoe-breuninger:masterfrom
rypti-org:master
Mar 31, 2026
Merged

[dataSourceNetboxVlans] - Add netbox_vlan.id in netbox_vlans.vlans DataSources#662
fbreckle merged 6 commits intoe-breuninger:masterfrom
rypti-org:master

Conversation

@rypti
Copy link
Copy Markdown
Contributor

@rypti rypti commented Dec 6, 2024

"update(dataSourceNetboxVlans): Add netbox_vlan.id info in return info of netbox_vlans.vlans"

Add netbox_vlan.id to "netbox_vlans (Data Source) > Nested Schema for vlans"
Allowing to use netbox_vlans to update Ressources and DataSources when "netbox_vlan" can't be used. (Identical vlan infos or only Read-Only info differentiates )

Can also be used with Vlans that didn't get created with the provider.

@fbreckle
Copy link
Copy Markdown
Collaborator

fbreckle commented Jan 7, 2025

I feel like just adding "assigned_id" as an output field is not very user-friendly. The AssignedObjectType field should be read and then set fields assigned_device_id, assigned_virtual_machine_id and possibly also assigned_object_type should be set in order to return all relevant info.

@rypti
Copy link
Copy Markdown
Contributor Author

rypti commented Jan 15, 2025

Hello,
Sorry, those commit were not meant to end up in the pull request only the modifications on "dataSourceNetboxVlans" are the target of this PR

@Isonami
Copy link
Copy Markdown

Isonami commented Feb 27, 2025

Hello,
I would also like to vote for this, this is really nice feature to have.

@rypti rypti force-pushed the master branch 2 times, most recently from 06bd94e to 4dfc18d Compare May 22, 2025 12:44
@fbreckle
Copy link
Copy Markdown
Collaborator

fbreckle commented Jun 3, 2025

Please also update the tests to check if the new attribute is actually present.

@rypti
Copy link
Copy Markdown
Contributor Author

rypti commented Jul 8, 2025

Please also update the tests to check if the new attribute is actually present.

Hello,
I added a test to check if the new attribute is actually present in the return of the datasource

@rypti
Copy link
Copy Markdown
Contributor Author

rypti commented Mar 30, 2026

Hey @fbreckle still no news ?

@fbreckle fbreckle merged commit 369fcd2 into e-breuninger:master Mar 31, 2026
23 checks passed
@fbreckle
Copy link
Copy Markdown
Collaborator

uhm, yeah. this took quite a while. sorry :\

@rypti
Copy link
Copy Markdown
Contributor Author

rypti commented Apr 1, 2026

I can understand, thank you for merging it :)

Have a good day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants