feat(datasource): add support for filtering netbox_prefix by custom fields#668
Open
xabinapal wants to merge 6 commits intoe-breuninger:masterfrom
Open
feat(datasource): add support for filtering netbox_prefix by custom fields#668xabinapal wants to merge 6 commits intoe-breuninger:masterfrom
xabinapal wants to merge 6 commits intoe-breuninger:masterfrom
Conversation
…fields Signed-off-by: Xabier Napal <xabier.napal@dvzr.io>
Signed-off-by: Xabier Napal <xabier.napal@dvzr.io>
Signed-off-by: Xabier Napal <xabier.napal@dvzr.io>
Signed-off-by: Xabier Napal <xabier.napal@dvzr.io>
Signed-off-by: Xabier Napal <xabier.napal@dvzr.io>
Contributor
|
What is the status on this? We would really like to have this merged. |
Contributor
|
Any update here? Can someone at least comment if something is missing, wrong or if you for some reason don't find this change beneficial? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to filter
netbox_prefixdatasource results by custom fields. While the datasource previously supported returning custom fields, it did not allow searching by them.Due to how the API library works, this functionality has been implemented with a custom request option to handle filtering by custom fields. The implementation is designed to be reusable, allowing other datasources to easily adopt custom field filtering with minimal effort in future updates.