Open
Conversation
MrKeiKun
force-pushed
the
fix-712-custom_fields-state-drift
branch
2 times, most recently
from
8de58de to
b6314a2
Compare
Contributor
Author
|
Want me to rebase this? @fbreckle |
MrKeiKun
force-pushed
the
fix-712-custom_fields-state-drift
branch
from
453d29f to
b1d3ca7
Compare
Contributor
Author
|
adjusting my fix since it sems introduces a problem |
… handling object references, and suppressing nil/empty diffs. Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
MrKeiKun
force-pushed
the
fix-712-custom_fields-state-drift
branch
from
b1d3ca7 to
2ad4cf9
Compare
Contributor
Author
|
@fbreckle for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
terraform planrepeatedly shows the same custom fields needing to be addedcloud_accountonnetbox_prefixresourcesChanges Made
flattenCustomFieldsfunctiongetCustomFields()toflattenCustomFields()and ensures consistent handling across all resources with custom fieldsDiffSuppressFuncwhich suppresses false positives between{}(empty map) and""(empty string) and prevents spurious drift on empty custom fieldsand
uses json.Numberto prevent type conversion issuesReferenced Issue: #712