feat: add strip-bom and strip-bom-string to replacements#692
Merged
Conversation
43081j
reviewed
May 31, 2026
| "id": "snippet::strip-bom", | ||
| "type": "simple", | ||
| "description": "You can check the start of a string for the BOM character and use `String.prototype.slice` if it is present.", | ||
| "example": "str.startsWith('\\ufeff') ? str.slice(1) : str;" |
Contributor
There was a problem hiding this comment.
its probably more efficient to use charCodeAt:
str.charCodeAt(0) === 0xFEFFsince its a numeric comparison, single character
Contributor
Author
There was a problem hiding this comment.
charCodeAt, since we are looking at the first character specifically, and 0xFEFF is in BMP
Contributor
There was a problem hiding this comment.
charCodeAt is faster than codePointAt in this case since we're retrieving the first character rather than having to compute the first code point (which could be a surrogate pair)
gameroman
commented
May 31, 2026
43081j
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #612
Closes #667
📚 Description
Adds
strip-bomandstrip-bom-stringto replacements