fix: support modern Chromium cookie restore - #129
Draft
chenggaofeng wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
__Host-and__Secure-prefix requirementsSameSite=unspecifiedvaluesWhy
The current restore path converts every cookie into a domain cookie and drops modern Chromium fields such as
partitionKey. Modern Chrome and Edge can reject those writes, especially for host-only cookies, partitioned cookies, cookie prefixes, or insecure URL/scheme combinations. The popup may report that synchronization completed even when part of the restore failed.This change normalizes the cookie payload before calling
cookies.set()and retries only with progressively safer representations when Chromium rejects the first form.User impact
Cookie restore works on current Chromium-based browsers without silently dropping modern cookie types. The extension badge now distinguishes complete success, partial success, and total failure.
Validation
node --test utils/cookie-normalization.test.ts— 6 tests passedpnpm compile— passedpnpm build:chrome— passedNo server API or encrypted data format changes are included.