ShortcutBuilder: make A-Z shortcuts layout-aware#646
Open
awsms wants to merge 1 commit into
Open
Conversation
Previously, shortcuts were built using a hardcoded scan-code-to-key map that assumed a QWERTY layout. This caused issues for users with different layouts, such as AZERTY, where keys like 'A' and 'Q' were swapped in keybinds. This change ensures that keys in the A-Z range use the actual key value provided by the event, making letter-based shortcuts layout-aware. Non-letter keys and non-Latin layouts still fallback to the native scan code map to maintain physical position consistency where appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, shortcuts were built using a hardcoded scan-code-to-key map that assumed a QWERTY layout.
This caused issues for users with different layouts, such as AZERTY, where keys like 'A' and 'Q' were swapped in keybinds.
This change ensures that keys in the A-Z range use the actual key value provided by the event, making letter-based shortcuts layout-aware. Non-letter keys and non-Latin layouts still fallback to the native scan code map to maintain physical position consistency where appropriate.
edit: fixes #338