Fix categorization stepper step order index, introduce new composition function for vue, fix config to be properly passed to test functions by kchobantonov · Pull Request #2522 · eclipsesource/jsonforms

kchobantonov · 2025-12-28T17:12:57Z

Make sure that category stepper is working correctly when making categories visible/hidden.
Introduce new composition functions in vue package (moved and enhanced from the vue-vuetify package) that are useful for vue and not related to vuetify
Fix the DispatchRenderer and DispatchCell to use the resolved config and pass that to the TestContext - otherwise since there is not mapping for the config whenever the or are called the config inside the testers is always undefined.

…hole to not affect the index based on visible catogories only

netlify · 2025-12-28T17:13:03Z

✅ Deploy Preview for jsonforms-examples ready!

Name	Link
🔨 Latest commit	`f9ef99e`
🔍 Latest deploy log	https://app.netlify.com/projects/jsonforms-examples/deploys/69fb7cb4a83ede0009588daf
😎 Deploy Preview	https://deploy-preview-2522--jsonforms-examples.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…xing

kchobantonov · 2025-12-28T20:18:19Z

@sdirix please review - this is fixing an issue with categorization where when we make categories visible/hidden then the tag/view is switched - the example is here - https://deploy-preview-2522--jsonforms-examples.netlify.app/vue-vuetify/#categorization-stepper-nav-buttons - note that when you select/deselect "Provide Address" or "Vegetarian" you are still on the same tab and that does not change

Also some type information for the Date/Time/DateTime renderers are fixed since the build was failing and also the vuetify library is updated

…config since the config is not been passed when <dispatch-renderer> or <dispatch-cell> are called

…ue package - like useJsonForms. change all placed to use the new composition functions

kchobantonov · 2025-12-30T17:28:56Z

@sdirix updated the PR with some other fixed that I have documented in the description.

coveralls · 2026-01-27T09:31:22Z

coverage: 82.959%. remained the same — kchobantonov:fix-categorization-stepper-step-order-index into eclipsesource:master

sdirix

The changes overall look good!

Note that the PR title says "Fix categorization stepper step order index, introduce new composition function for vue, fix config to be properly passed to test functions" but it actually also includes:

Vuetify version bump (3.9 -> 3.11)
useMask reactivity fix in Date/Time/DateTime controls
clearable behavior change (AND with enabled)
controlWrapper source change (using overwrittenControl instead of input.control)
undefined -> null type fixes in picker values
activator="parent" removal from menus
DateTime onPickerChange rewrite
min/max exclusive fix for DateTimeControlRenderer

These are all independent fixes. Splitting into separate PRs would make each easier to review. This PR contained so much again that I pushed reviewing too later to when I have more time.

…t parameter as it was before then that is gurantee to return JsonFormsSubStates and not JsonFormsSubStates | undefined while if we use that change we need to check for undefined

kchobantonov · 2026-03-05T15:20:24Z

@sdirix all fixed and added comment above for the need of
const jsonforms = optional === true ? useJsonForms(true) : useJsonForms();

sdirix · 2026-04-06T21:41:13Z

I will take a look at this PR again next week

kchobantonov · 2026-05-06T17:39:39Z

@sdirix changes are done - please review again - thanks

sdirix · 2026-05-28T13:47:11Z

          <v-tab
-            v-for="(_, index) in visibleCategories"
-            :key="`${layout.path}-${visibleCategories.length}-${index}`"
+            v-for="entry in visibleCategoriesWithIndex"


When the active tab's neighbour becomes hidden, the tab strip ends up with no visually selected tab because this is still position based.

sdirix · 2026-05-28T13:47:14Z

        if (date) {
          // the format is exclusive
-          date = date.add(1, 'second');
+          date = date.add(1, this.useSeconds ? 'second' : 'minutes');


'minutes' (plural) mixed with 'second' (singular) is inconsistent with the rest of this file, which uses 'minute' and 'second'.

sdirix · 2026-05-28T13:48:11Z

+
+  if (!jsonforms && !optional) {
+    throw new Error(
+      "'jsonforms couldn't be injected. Are you within JSON Forms?"


Pre-existing typo carried over from vue-vuetify: missing closing single quote after jsonforms. Same problem on lines 558, 578, 600 for useDispatch, useTranslator, useAjv. Worth fixing while you're already touching this code.

sdirix · 2026-05-28T14:24:43Z

+    return jsonforms!.i18n!.translate!;
+  });
+
+  return translate;


When optional=true and no jsonforms is injected, this still returns the computed (the overload says ComputedRef<Translator> | undefined, but the body always returns translate). Accessing .value then dereferences jsonforms!.i18n!.translate! on undefined and throws. That breaks the use case in ValidationBadge.vue, which previously got a clean null and now will throw the first time the template evaluates t. Return undefined early when jsonforms (or its translator) is missing in the optional path.

kchobantonov added 2 commits December 28, 2025 12:11

make sure that the index is based on the categories collection as a w…

376e353

…hole to not affect the index based on visible catogories only

update vuetify

8e95515

kchobantonov added 4 commits December 28, 2025 12:15

do not use another compute array for labels since of a different inde…

46dae05

…xing

use better check for the v-divider visibility

ccc9ffe

apply the same fix for the visible categories

ed793f9

fix types

eac67fd

kchobantonov added 2 commits December 30, 2025 12:24

use the resolved config so that testers will have access to the root …

264e33d

…config since the config is not been passed when <dispatch-renderer> or <dispatch-cell> are called

move generic vue composition function not related to vuetify in the v…

4a0edec

…ue package - like useJsonForms. change all placed to use the new composition functions

kchobantonov changed the title ~~Fix categorization stepper step order index~~ Fix categorization stepper step order index, introduce new composition function for vue, fix config to be properly passed to test functions Dec 30, 2025

Merge branch 'master' into fix-categorization-stepper-step-order-index

3c37e42

kchobantonov added 5 commits February 1, 2026 23:59

Merge branch 'master' into fix-categorization-stepper-step-order-index

fffd33c

enable the clearable only if the input is enabled

00b2b6a

fix combined

61ec1a4

fix the min/max exclusive

737ff6a

fix controlWrapper to take props from the overwrittenControl

9a07399

sdirix requested changes Mar 5, 2026

View reviewed changes

Comment thread packages/vue-vuetify/src/controls/DateControlRenderer.vue Outdated

Comment thread packages/vue/src/jsonFormsCompositions.ts Outdated

Comment thread packages/vue/src/jsonFormsCompositions.ts Outdated

kchobantonov added 7 commits March 5, 2026 09:15

Merge branch 'master' into fix-categorization-stepper-step-order-index

e5e68be

pass the optional boolean value

8de2c5f

fix mask options to be properly reactive

4820db2

revert back the use of optional since if we use useJsonForms() withou…

2c08545

…t parameter as it was before then that is gurantee to return JsonFormsSubStates and not JsonFormsSubStates | undefined while if we use that change we need to check for undefined

Merge branch 'master' into fix-categorization-stepper-step-order-index

eccfa43

use the lock from master

3bbd4a7

update lock file

196f100

kchobantonov requested a review from sdirix March 5, 2026 15:19

Merge branch 'master' into fix-categorization-stepper-step-order-index

943fcc4

Merge branch 'master' into fix-categorization-stepper-step-order-index

3a34907

kchobantonov added 3 commits April 18, 2026 19:53

Merge branch 'master' into fix-categorization-stepper-step-order-index

705ad48

update lock file

224e1a2

fix merge issues

c956f4f

sdirix requested changes May 4, 2026

View reviewed changes

Comment thread packages/vue/src/jsonFormsCompositions.ts Outdated

Comment thread packages/vue-vuetify/src/layouts/CategorizationStepperRenderer.vue

Comment thread packages/vue-vuetify/src/layouts/CategorizationStepperRenderer.vue

kchobantonov added 3 commits May 6, 2026 11:49

update snapshots

cccb6ca

Merge branch 'master' into fix-categorization-stepper-step-order-index

9bde511

address the latest code review

f9ef99e

kchobantonov requested a review from sdirix May 6, 2026 17:39

sdirix requested changes May 28, 2026

View reviewed changes

Conversation

kchobantonov commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jsonforms-examples ready!

Uh oh!

kchobantonov commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kchobantonov commented Dec 30, 2025

Uh oh!

coveralls commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sdirix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kchobantonov commented Mar 5, 2026

Uh oh!

sdirix commented Apr 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kchobantonov commented May 6, 2026

Uh oh!

sdirix May 28, 2026

Choose a reason for hiding this comment

Uh oh!

sdirix May 28, 2026

Choose a reason for hiding this comment

Uh oh!

sdirix May 28, 2026

Choose a reason for hiding this comment

Uh oh!

sdirix May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kchobantonov commented Dec 28, 2025 •

edited

Loading

netlify Bot commented Dec 28, 2025 •

edited

Loading

kchobantonov commented Dec 28, 2025 •

edited

Loading

coveralls commented Jan 27, 2026 •

edited

Loading