Skip to content

Feat: regexp support for path#7

Open
zjz19901029 wants to merge 3 commits into
eggjs:masterfrom
zjz19901029:feat-regexp-support
Open

Feat: regexp support for path#7
zjz19901029 wants to merge 3 commits into
eggjs:masterfrom
zjz19901029:feat-regexp-support

Conversation

@zjz19901029

Copy link
Copy Markdown
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

add a function getRegExp() , to handle prefix and path when the path is a regexp , it will get a new regexp within prefix and path
remove 'path' from "Note: `prefix` and `path` are not allow to be `regex`."
@codecov

codecov Bot commented Apr 26, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          38     41    +3     
=====================================
+ Hits           38     41    +3
Impacted Files Coverage Δ
lib/router.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299a47a...15c0a4c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant