add biome client - #5103
Open
pradyuman wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
documentation
client
pradyuman
force-pushed
the
codex/add-biome-client
branch
2 times, most recently
from
August 2, 2026 20:27
135aebf to
b5dfcc4
Compare
pradyuman
force-pushed
the
codex/add-biome-client
branch
from
August 2, 2026 20:30
b5dfcc4 to
6a691fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#5007 added
lsp-biometolsp-client-packagesand the documentation navigation, but did not add a client implementation. Because client packages are loaded optionally, Biome support is otherwise silently skipped unless an external package provides the feature. This PR completes that in-tree integration.The implementation follows existing in-tree client and dependency APIs and is based on Biome's documented LSP contract. It take a different approach from the external
cxa/lsp-biomepackage, and instead aims to match defaultbiome lsp-proxybehavior as closely as possible (including relying onlsp-modecode action facilities, exposing biome languge server configuration settings, supporting multi-root, etc).Testing
nix shell nixpkgs#eask-cli -c make compile EASK=easkpackage-lintforclients/lsp-biome.elcheckdocforclients/lsp-biome.eldocs/page/lsp-biome.mdsuccessfullylsp-modeand formatted a TypeScript buffer using the real LSP server