#1741 - enhancement: improve agent registration failure messages and empty shell listing. by simeshev · Pull Request #1786 · embabel/embabel-agent

simeshev · 2026-07-13T22:45:40Z

No description provided.

… empty shell listing. Signed-off-by: Slava Imeshev <imeshev@yahoo.com>

Copilot

Pull request overview

This PR addresses issue #1741 by improving user-facing output when listing agents in the shell (including an empty state) and by making agent auto-registration failures more explicit and actionable through clearer warnings and stricter validation.

Changes:

Add an explicit empty-state response for the agents shell command and preserve detailed output + a concise summary when agents exist.
Improve agent registration failure warnings and enforce non-registration on GOAP validation failures, with new regression tests covering these cases.
Adjust logging severity when an agent process runs with no goals (where goals are required).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
embabel-agent-shell/src/test/kotlin/com/embabel/agent/shell/ShellCommandsAgentsTest.kt	Adds regression tests for `agents` command empty-state and detailed/summary output.
embabel-agent-shell/src/main/kotlin/com/embabel/agent/shell/ShellCommands.kt	Implements empty-state handling and uses a `Summary` section for agents/actions listings.
embabel-agent-api/src/test/kotlin/com/embabel/agent/api/annotation/support/testTypes.kt	Adds new annotated test agent types to exercise registration/validation failure cases.
embabel-agent-api/src/test/kotlin/com/embabel/agent/api/annotation/support/AgentMetadataReaderMetadataTest.kt	Adds OutputCapture-based assertions ensuring explicit “not registered” warnings are logged.
embabel-agent-api/src/main/kotlin/com/embabel/agent/core/support/AbstractAgentProcess.kt	Raises log level to error when a goals-required process has no goals.
embabel-agent-api/src/main/kotlin/com/embabel/agent/api/annotation/support/AgentMetadataReader.kt	Improves warning messages for registration failures and returns null on GOAP validation failure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…puts Nullable domain params skip the input precondition, so path validation failed with NO_PATH_TO_GOAL and createAgentMetadata returned null. Keep planner=GOAP; fix RetryActionAnnotationTest and ActionRetryPolicyPropertiesTest fixtures only. Signed-off-by: Slava Imeshev <imeshev@yahoo.com>

…lorPalette implementation via an anonymous ColorPalette object. Using DefaultColorPalette directly avoids duplication and keeps the test aligned if the default palette changes." Signed-off-by: Slava Imeshev <imeshev@yahoo.com>

igordayen · 2026-07-14T11:53:39Z

@deleSerna - can it be closed, as you opened the issue? thanks.

deleSerna

can it be closed, as you opened the issue?
Yes, the PR looks good to me.

igordayen

@simeshev - looks good, few comments to consider, thanks.

igordayen · 2026-07-15T00:09:18Z

-                // TODO: Uncomment to strengthen validation and refactor the test if needed. Because some tests might fail.
-                // return null
+                logger.warn(
+                    "❓Agent {} is not registered due to validation failure:\n{}",


The prefix Agent is applied repeatedly. Please consider constant as a prefix. thanks.

The prefix Agent is applied repeatedly. Please consider constant as a prefix. thanks.

This a throw-away literal. GC will take care of it. We have a lot of them, registered, planner etc. for example. If we start replacing them with constants, it will be hard(er) to read. Plus, PR blast radius will be much bigger and I'd prefer the changes to be surgical.

I'd rather keep it.

igordayen · 2026-07-15T00:10:39Z

    @AchievesGoal(description = "Process the input")
    @Action(actionRetryPolicyExpression = "\${retry-twice}")
-    fun perform(input: JavaRetryTestInput?): JavaRetryTestOutput {
+    fun perform(input: JavaRetryTestInput): JavaRetryTestOutput {


Guaranteed not null?

azanux

Thanks @simeshev , everything looks good, just one small blocker to check.

Nothing to do with your PR but it could impact the PR, so it would be nice to fix it at the same time:

AgentMetadataReader.kt:84: + instead of += returns a new list and the result is discarded, so the error is never added. A blank @Agent(description = "") produces no warning at all: validationErrors() comes back empty and the agent registers silently.

azanux · 2026-07-15T04:30:55Z

+                    agent.name,
+                    validationResult.errors.joinToString("\n"),
+                )
+                return null


Agents whose goal action takes no input (or only a nullable one) silently stop registering.
agents that failed validation used to register with a warning, now they don't register at all.

Not sure but the bug seems to be in GoapPathToCompletionValidator.kt:215:

if (plan == null || plan.actions.isEmpty()) { // → NO_PATH_TO_GOAL

@simeshev @azanux - good point, for pointing to GoapPathToCompletionValidator ==> so it will be at the very end, properly reported, if there are no actions, per my understanding; rather than updating half a dozen log statements with the same PREFIX, it actually gets accommodated in a single place, correct?

@igordayen It depends on how @simeshev resolve the behaviour change first: this PR uncommented the return null at line 313 : Agents whose goal action takes no input (or only a nullable one) used to register with a warning, and now don't register at all

On your point: partially right. Line 309 is the only warn fed by the validator, so that path is centralised. But lines others are early return nulls - validate() is only called at line 306, so they exit before it and never reach GoapPathToCompletionValidator.

azanux · 2026-07-15T04:42:47Z

                        logger.warn(
-                            "Agent {} has @AchievesGoal actions returning distinct types [{}] - rejected. Set embabel.agent.platform.planner.restricted-goals=false to allow",
-                            targetType.name,
+                            "❓Agent {} is not registered due to @AchievesGoal actions returning distinct types [{}]. Set embabel.agent.platform.planner.restricted-goals=false to allow",


agentName() returns the logical name (@Agent(name = "star-wars-fan")), not the
class, so the log gives no clue which file to open - and this is the path where the
agent gets removed, so we need it most.

@azanux - Here is what agenName() does. If the name is blank, agenName() returns type name:

fun agentName(): String = (agentAnnotation?.name ?: "").ifBlank { targetType.simpleName }

@azanux - maybe you meant: ?

logger.warn( "❓Agent {} is not registered due to validation failure:\n{}", agent.name, validationResult.errors.joinToString("\n"),

If so, I've replaced agent.name with agenticInfo.agentName() that does provide type name in case the agent name annotation is blank.

azanux · 2026-07-15T04:55:23Z

    @AchievesGoal(description = "Process the input")
    @Action(actionRetryPolicyExpression = "\${retry-twice}")
-    fun firstAction(input: RetryTestInput?): RetryTestOutput {
+    fun firstAction(input: RetryTestInput): RetryTestOutput {


This test covers retry behaviour, not sure that input nullability have to do with it.
maybe this needed because the new return null in AgentMetadataReader stops the agent registering, rather than because the fixture was wrong?

igordayen

@azanux - thanks for feedback, appears, morre attention required then.

…(name = "star-wars-fan")), not the class, so the log gives no clue which file to open - and this is the path where the agent gets removed, so we need it most." Signed-off-by: Slava Imeshev <imeshev@yahoo.com>

sonarqubecloud · 2026-07-15T17:14:12Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

#1741 - enhancement: improve agent registration failure messages and…

90183b6

… empty shell listing. Signed-off-by: Slava Imeshev <imeshev@yahoo.com>

Copilot AI review requested due to automatic review settings July 13, 2026 22:45

simeshev linked an issue Jul 13, 2026 that may be closed by this pull request

Improve the warning message when Agent does not meet the necessary criteria to register as an Agent #1741

Open

Copilot started reviewing on behalf of simeshev July 13, 2026 22:46 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread embabel-agent-shell/src/test/kotlin/com/embabel/agent/shell/ShellCommandsAgentsTest.kt Outdated

simeshev added 2 commits July 13, 2026 16:32

simeshev requested review from alexheifetz, azanux and igordayen July 14, 2026 01:04

igordayen mentioned this pull request Jul 14, 2026

Improve the warning message when Agent does not meet the necessary criteria to register as an Agent #1741

Open

deleSerna approved these changes Jul 14, 2026

View reviewed changes

igordayen reviewed Jul 15, 2026

View reviewed changes

azanux reviewed Jul 15, 2026

View reviewed changes

igordayen requested changes Jul 15, 2026

View reviewed changes

#1741 - resolved feedback "agentName() returns the logical name (@agent…

4dbb8ba

…(name = "star-wars-fan")), not the class, so the log gives no clue which file to open - and this is the path where the agent gets removed, so we need it most." Signed-off-by: Slava Imeshev <imeshev@yahoo.com>

Uh oh!

Conversation

simeshev commented Jul 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

igordayen commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deleSerna left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igordayen left a comment

Choose a reason for hiding this comment

Uh oh!

igordayen Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simeshev Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azanux left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simeshev Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igordayen left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 15, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

igordayen commented Jul 14, 2026 •

edited

Loading

deleSerna left a comment •

edited

Loading

igordayen Jul 15, 2026 •

edited

Loading

simeshev Jul 15, 2026 •

edited

Loading

simeshev Jul 15, 2026 •

edited

Loading