[libc] Handle overflow in localtime and gmtime#27187
Open
sbc100 wants to merge 1 commit into
Open
Conversation
Modify `_localtime_js` and `_gmtime_js` to return success/failure status, and update `__localtime_r` and `__gmtime_r` to return NULL when they fail. Previously, these JS helper functions returned `void` and would write invalid/NaN values to the `tm` struct when the input time was out of range of the JS `Date` object. This could trigger assertions or result in garbage data. This completes the work started in 722a1b7 (which fixed `mktime` but left `localtime`/`gmtime` unhandled). Added tests to verify: - `localtime` and `gmtime` return NULL on overflow. - `localtime_r` does not modify the `tm` struct on failure. See: emscripten-core#26704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify
_localtime_jsand_gmtime_jsto return success/failure status, and update__localtime_rand__gmtime_rto return NULL when they fail.Previously, these JS helper functions returned
voidand would write invalid/NaN values to thetmstruct when the input time was out of range of the JSDateobject. This could trigger assertions or result in garbage data.This completes the work started in #26704 (which fixed
mktimebut leftlocaltime/gmtimeunhandled).Added tests to verify:
localtimeandgmtimereturn NULL on overflow.localtime_rdoes not modify thetmstruct on failure.See: #26704