add boxedwine#5887
Conversation
|
Can you create some tests please ? |
|
Hello. Do you mean the tests section in recipe.yaml? It has already been there: |
IsabelParedes
left a comment
There was a problem hiding this comment.
A couple of changes needed.
It seems that you are packaging the entire build directory including the object files, this shouldn't be needed.
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_approxRecip_1Ks.c.o (602 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_countLeadingZeros32.c.o (597 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_countLeadingZeros64.c.o (629 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_countLeadingZeros8.c.o (726 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_le128.c.o (452 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_lt128.c.o (452 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_mul64ByShifted32To128.c.o (481 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_mul64To128.c.o (516 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_normRoundPackToExtF80.c.o (754 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_normRoundPackToF32.c.o (622 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_normRoundPackToF64.c.o (631 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_normSubnormalExtF80Sig.c.o (533 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_normSubnormalF32Sig.c.o (532 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_normSubnormalF64Sig.c.o (533 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_roundPackToExtF80.c.o (1.86 KiB)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_roundPackToF32.c.o (1.04 KiB)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_roundPackToF64.c.o (1.10 KiB)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_roundToI32.c.o (781 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_roundToI64.c.o (772 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_roundToUI32.c.o (765 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_roundToUI64.c.o (761 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_shiftRightJam128.c.o (561 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_shiftRightJam32.c.o (462 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_shiftRightJam64.c.o (469 B)
├─ share/boxedwine-single-thread/home/runner/work/recipes/recipes/output/bld/rattler-build_boxedwine-single-thread_1784113409/work/lib/softfloat/source/s_shiftRightJam64Extra.c.o (516 B)
And when testing the packaged websites, they also do not seem to work so well.
Thank you!
There was a problem hiding this comment.
Multi-threading generally doesn't work out of the box
There was a problem hiding this comment.
Yes. It needs coop and coep header, either from server side or by a service worker.
It requires a wine filesystem. The release in its github repo provide one. Building it is quite complicated. See https://github.com/danoon2/Boxedwine/blob/master/docs/How-To-Build-Wine-FileSystem.md for more details. |
Pre-submission Checks
emscripten-wasm32platform (not a noarch package), in other words, the package requires compilation.Recipe Structure
Added
recipes/recipes_emscripten/[package-name]/recipe.yamlwith proper structure:contextsection withversion(and optionallyname)packagesection with name and version using Jinja2 templatessourcesection with:.tar.gz,.tar.bz2,.tar.xz,.tgz, or.zip)${{ version }}template for version updatescurl -sL <url> | sha256sum)[package-name]/patches/directorybuildsection with appropriate script/method${PYTHON} -m pip install . ${PIP_ARGS}$R CMD INSTALL $R_ARGS .emcmake/emmakeoremconfigure/emmakerust-nightlyandmaturinor appropriate Rust build toolrequirementssection (build, host, run as needed)testssectiontest_import_[package].pyfile created and referencedaboutsection with license, homepage, summaryPR Formatting
Add [package-name]orUpdate [package-name] to [version]Package Details
Build Notes