add gap-in-the-browser#5891
Draft
wangyenshu wants to merge 1 commit into
Draft
Conversation
mkoeppe
reviewed
Jul 21, 2026
Comment on lines
+44
to
+68
| ( | ||
| mkdir -p "$AUX_BUILD/gmp" | ||
| cd "$AUX_BUILD/gmp" && | ||
| if [[ ! -f config.status ]]; then | ||
| CC_FOR_BUILD=/usr/bin/gcc ABI=standard \ | ||
| emconfigure $BASEDIR/extern/gmp/configure \ | ||
| --build i686-pc-linux-gnu --host none \ | ||
| --disable-assembly --enable-cxx \ | ||
| --prefix=$AUX_PREFIX | ||
| fi && | ||
| emmake make -j8 && | ||
| emmake make install | ||
| ) | ||
|
|
||
| ( | ||
| mkdir -p "$AUX_BUILD/zlib" | ||
| cd "$AUX_BUILD/zlib" && | ||
| if [[ ! -f Makefile ]]; then | ||
| # --- MODIFICATION: Added --static to prevent shared library linkage errors --- | ||
| emconfigure $BASEDIR/extern/zlib/configure --static --prefix=$AUX_PREFIX | ||
| fi; | ||
| emmake make -j8 && | ||
| emmake make install | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
Surely these two packages can just be taken from emscripten-forge instead of rebuilding them here from source?
(Same in #5866 -- I don't know which of the two to review)
wangyenshu
marked this pull request as draft
July 25, 2026 04:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission Checks
emscripten-wasm32platform (not a noarch package), in other words, the package requires compilation.Recipe Structure
Added
recipes/recipes_emscripten/[package-name]/recipe.yamlwith proper structure:contextsection withversion(and optionallyname)packagesection with name and version using Jinja2 templatessourcesection with:.tar.gz,.tar.bz2,.tar.xz,.tgz, or.zip)${{ version }}template for version updatescurl -sL <url> | sha256sum)[package-name]/patches/directorybuildsection with appropriate script/method${PYTHON} -m pip install . ${PIP_ARGS}$R CMD INSTALL $R_ARGS .emcmake/emmakeoremconfigure/emmakerust-nightlyandmaturinor appropriate Rust build toolrequirementssection (build, host, run as needed)testssectiontest_import_[package].pyfile created and referencedaboutsection with license, homepage, summaryPR Formatting
Add [package-name]orUpdate [package-name] to [version]Package Details
Build Notes
This recipe will build gap-in-the-browser. The output should be the same as https://gap-system.github.io/gap-in-the-browser/.