-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Fix BookListSerializer update example logic to support creation #9990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JPisOP007
wants to merge
1
commit into
encode:main
Choose a base branch
from
JPisOP007:fix/docs-book-list-serializer-update-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -805,7 +805,8 @@ Here's an example of how you might choose to implement multiple updates: | |
| def update(self, instance, validated_data): | ||
| # Maps for id->instance and id->data item. | ||
| book_mapping = {book.id: book for book in instance} | ||
| data_mapping = {item['id']: item for item in validated_data} | ||
| data_mapping = {item['id']: item for item in validated_data if 'id' in item} | ||
| new_items = [item for item in validated_data if 'id' not in item] | ||
|
|
||
| # Perform creations and updates. | ||
| ret = [] | ||
|
|
@@ -816,6 +817,9 @@ Here's an example of how you might choose to implement multiple updates: | |
| else: | ||
| ret.append(self.child.update(book, data)) | ||
|
|
||
| for data in new_items: | ||
| ret.append(self.child.create(data)) | ||
|
|
||
| # Perform deletions. | ||
| for book_id, book in book_mapping.items(): | ||
| if book_id not in data_mapping: | ||
|
|
@@ -826,7 +830,8 @@ Here's an example of how you might choose to implement multiple updates: | |
| class BookSerializer(serializers.Serializer): | ||
| # We need to identify elements in the list using their primary key, | ||
| # so use a writable field here, rather than the default which would be read-only. | ||
| id = serializers.IntegerField() | ||
| # The id is optional so that new items (without an id) can be created. | ||
| id = serializers.IntegerField(required=False) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense given the new create path. |
||
| ... | ||
|
|
||
| class Meta: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this could be a single loop instead of two separate comprehensions, to avoid iterating
validated_datatwice — e.g.: