Add class method visibility to currently implicit methods#770
Open
Ayesh wants to merge 1 commit intoerusev:masterfrom
Ayesh:method-visibility
Open
Add class method visibility to currently implicit methods#770Ayesh wants to merge 1 commit intoerusev:masterfrom Ayesh:method-visibility
Ayesh wants to merge 1 commit intoerusev:masterfrom
Ayesh:method-visibility
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are few methods in the
Parsedownclass that do not explicitly declare visibility. Protected methods are declared as such, but I would like to propose that we mark all implicit public methods as public.It's considered a good practice, and PSR-2 and 12 both recommend to declare visibility modifiers too.