Fix #370, make TimeTriggerConfig pub and add examples for time_trigger#372
Fix #370, make TimeTriggerConfig pub and add examples for time_trigger#372
time_trigger#372Conversation
00b9b1c to
02a9f86
Compare
02a9f86 to
bbfad0e
Compare
|
Fix CI at #377 |
estk
left a comment
There was a problem hiding this comment.
Nice example!
One question added.
bbfad0e to
9fa2936
Compare
|
This is gtg, just waiting on the #367 |
|
any updates on this come on pls |
1 similar comment
|
any updates on this come on pls |
|
Still waiting on the other PR |
|
i copied it over to my machine and i see that it only triggers for the current process, for example, if i set the time interval to be 1 minute and i kill it and start again after one minute it doesnt roll the log. i would like this lib to be exactly like the NLog in c# |
|
Thanks. You are right about it. For now, I use static variable to store the start time, so after closing the program, the timer will restart. My next goal is to read the start time from file, which will solve your issue. However, now we have a series of PR blocked, including some big structural changes. Therefore, I plan to do it after these PR merged(If I still have time). |
|
Ok no problems, thank you. For now i will use SizeTrigger. |
|
@Dirreke can you please rebase this on main |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 63.39% 63.01% -0.38%
==========================================
Files 24 25 +1
Lines 1557 1617 +60
==========================================
+ Hits 987 1019 +32
- Misses 570 598 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Close #370