Skip to content

Fix #370, make TimeTriggerConfig pub and add examples for time_trigger#372

Merged
estk merged 1 commit intoestk:mainfrom
Dirreke:pub-timetrigger-config
May 27, 2025
Merged

Fix #370, make TimeTriggerConfig pub and add examples for time_trigger#372
estk merged 1 commit intoestk:mainfrom
Dirreke:pub-timetrigger-config

Conversation

@Dirreke
Copy link
Copy Markdown
Contributor

@Dirreke Dirreke commented May 3, 2024

Close #370

@Dirreke Dirreke requested review from estk and gadunga as code owners May 3, 2024 06:23
@Dirreke Dirreke force-pushed the pub-timetrigger-config branch 2 times, most recently from 00b9b1c to 02a9f86 Compare May 3, 2024 06:28
Comment thread examples/log_to_file_with_rolling_and_time_trigger.rs Outdated
Comment thread examples/log_to_file_with_rolling_and_time_trigger.rs Outdated
@Dirreke Dirreke force-pushed the pub-timetrigger-config branch from 02a9f86 to bbfad0e Compare July 7, 2024 13:48
@Dirreke
Copy link
Copy Markdown
Contributor Author

Dirreke commented Jul 7, 2024

Fix CI at #377

Comment thread src/append/rolling_file/policy/compound/trigger/time.rs Outdated
Copy link
Copy Markdown
Owner

@estk estk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example!

One question added.

@Dirreke Dirreke force-pushed the pub-timetrigger-config branch from bbfad0e to 9fa2936 Compare July 9, 2024 05:07
@estk
Copy link
Copy Markdown
Owner

estk commented Jul 9, 2024

This is gtg, just waiting on the #367

@jonygomes06
Copy link
Copy Markdown

any updates on this come on pls

1 similar comment
@jonygomes06
Copy link
Copy Markdown

any updates on this come on pls

@gauntl3t12
Copy link
Copy Markdown
Contributor

Still waiting on the other PR

@jonygomes06
Copy link
Copy Markdown

i copied it over to my machine and i see that it only triggers for the current process, for example, if i set the time interval to be 1 minute and i kill it and start again after one minute it doesnt roll the log. i would like this lib to be exactly like the NLog in c#
thank you

@Dirreke
Copy link
Copy Markdown
Contributor Author

Dirreke commented Aug 3, 2024

Thanks. You are right about it. For now, I use static variable to store the start time, so after closing the program, the timer will restart.

My next goal is to read the start time from file, which will solve your issue. However, now we have a series of PR blocked, including some big structural changes. Therefore, I plan to do it after these PR merged(If I still have time).

@jonygomes06
Copy link
Copy Markdown

Ok no problems, thank you. For now i will use SizeTrigger.

@estk
Copy link
Copy Markdown
Owner

estk commented May 26, 2025

@Dirreke can you please rebase this on main

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.01%. Comparing base (8ab1b34) to head (4f765cf).
Report is 12 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   63.39%   63.01%   -0.38%     
==========================================
  Files          24       25       +1     
  Lines        1557     1617      +60     
==========================================
+ Hits          987     1019      +32     
- Misses        570      598      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@estk estk merged commit 5f75d43 into estk:main May 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TimeTriggerConfig pub

5 participants