Open
Conversation
The previous <0.8.10 upper bound was added to avoid the MSRV bump that toml 0.8.10 introduced (1.67 to 1.69). That rationale no longer applies: this crate now sets rust-version = "1.82", so any toml MSRV between 1.65 and 1.75 is well below the floor. toml 0.9's MSRV is 1.66, which is strictly lower than the disallowed toml 0.8.10 (1.69). The single call site (src/config/file.rs:136) uses toml::from_str, which is stable across 0.8 and 0.9. No code changes are required. Verified: cargo build cargo build --features toml_format cargo build --all-features cargo test --features toml_format (4 passed, 0 failed) cargo test --all-features (4 passed, 0 failed) cargo clippy --all-features --all-targets -- -D warnings cargo fmt --all --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
<0.8.10upper bound ontomlwas set to avoid the MSRV bump that toml 0.8.10 introduced (1.67 to 1.69). That concern no longer applies:log4rsnow setsrust-version = "1.82", far above the range any version oftomlwould require.toml 0.9.0's MSRV is1.66, actually lower than the disallowedtoml 0.8.10(1.69). Moving to 0.9 is MSRV-neutral on this crate.The single call site is
src/config/file.rs:136, which usestoml::from_str(source). That entry point is stable across 0.8 and 0.9, so no source changes are needed.Verification
cargo build: cleancargo build --features toml_format: cleancargo build --all-features: cleancargo test --features toml_format: 4 passed, 0 failedcargo test --all-features: 4 passed, 0 failedcargo clippy --all-features --all-targets -- -D warnings: cleancargo fmt --all --check: cleanPrior related PRs
PR #348 and PR #381 previously attempted to move
tomlforward and were closed on MSRV grounds. Current MSRV (1.82) is now much higher than anything the toml bump would force, so that consideration is resolved.