alloy-op-evm,kona: cover SDM refund settlement and gas accounting - #22613
Open
nonsense wants to merge 2 commits into
Open
alloy-op-evm,kona: cover SDM refund settlement and gas accounting#22613nonsense wants to merge 2 commits into
nonsense wants to merge 2 commits into
Conversation
nonsense
force-pushed
the
nonsense/sdm-fault-proof-mips-coverage
branch
2 times, most recently
from
August 24, 2026 17:57
d6c166c to
73ddd09
Compare
nonsense
marked this pull request as ready for review
August 24, 2026 18:08
nonsense
force-pushed
the
nonsense/sdm-fault-proof-mips-coverage
branch
from
August 24, 2026 18:29
73ddd09 to
53408c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operator_fee_chargereturn zero before Isthmus before accessing Isthmus-only L1 block fields, with unit-test coverageWhy
The executor tests covered empty PostExec payloads and invalid non-empty payloads, but not successful settlement with non-zero refunds. Exercising that path with the existing pre-Isthmus fixture also exposed that operator-fee calculation could read missing Isthmus-only fields even though operator fees do not exist before Isthmus.
SDM refunds are applied after EVM execution, including after EIP-7623's calldata floor. When a refund lowered canonical gas below that floor, the generic execution-result view remained clamped to the original floor and diverged from canonical block and receipt gas accounting. Discounting the stored floor by the same post-execution refund preserves the intended ordering and keeps all gas views consistent.
Testing
cargo nextest run --release -p kona-executorcargo nextest run --release -p op-revm test_operator_fee_charge_formulascargo nextest run -p alloy-op-evmcargo clippy -p alloy-op-evm --all-targets --all-features -- -D warningscargo check -p alloy-op-evm --no-default-features