PortalNetwork: REPL Interface for Portal Network#721
Open
cjustinobi wants to merge 7 commits intoethereumjs:masterfrom
Open
PortalNetwork: REPL Interface for Portal Network#721cjustinobi wants to merge 7 commits intoethereumjs:masterfrom
cjustinobi wants to merge 7 commits intoethereumjs:masterfrom
Conversation
Contributor
Author
|
@acolytec3 I just want to make sure I'm in the right track. Please your feedback |
acolytec3
reviewed
Jan 24, 2025
Collaborator
acolytec3
left a comment
acolytec3
left a comment
There was a problem hiding this comment.
Looks good so far. I pushed a couple of tweaks so it will actually connect to the network now. You can also tune the logs it shows because the stuff you have now is a lot of logs.
Contributor
Author
|
Alright. Also, the methods I implemented so far are as a result of what I saw from here Are there more stuff I could have done there? |
Collaborator
|
The full rpc spec is here I don't think we need to implement all of them but maybe like |
cjustinobi
changed the title
acolytec3
approved these changes
Jan 30, 2025
Collaborator
acolytec3
left a comment
acolytec3
left a comment
There was a problem hiding this comment.
LGTM. We need a different (more accurate) mechanism for enforcing "first ping is type 0", maybe through an enr cache that we've played around with in the past.
Deejae69
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a REPL interface for interacting with the Portal Network, enabling developers to test and manage the network more effectively.
Features:
REPL Commands:
.ping <network>: Send a ping request to the specified network (historyorstate)..findnodes <network> <enr> <distances>: Locate nodes within a network using an ENR and distances..findcontent <network> <enr> <contentKey>: Search for content in a network using an ENR and content key..offer <network> <enr> <contentKey> <contentValue>: Offer content to a node in the specified network..status: Display the current status of the Portal Network and its components.