test: cover toolRegistry selection and metadata helpers - #382
Open
samarth70 wants to merge 1 commit into
Open
Conversation
toolRegistry.ts had no test coverage despite holding the pure logic that drives tool selection. Add tests/unit/toolRegistry.test.ts for: - isToolEnabledByDefault / requiresUserProvidedApiKey / isAgentTool reading the registry flags (incl. isAgentTool agreeing with AGENT_TOOL_IDS registry-wide); - expandToolSelection: agent_tools alias expansion, dedup with first-seen order, dedup across an alias and an explicit member, and silent-skip of unknown ids; - listToolMetadata: only registered tools marked enabled, full-registry coverage, and name/description surfaced for every entry. Tests only; no source changes.
|
@samarth70 is attempting to deploy a commit to the Exa Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/toolRegistry.tshad no test coverage, despite holding the pure logic that drives tool selection and metadata. This addstests/unit/toolRegistry.test.tscovering:isToolEnabledByDefault/requiresUserProvidedApiKey/isAgentTool— reading the registry flags, includingisAgentToolagreeing withAGENT_TOOL_IDSacross the whole registry.expandToolSelection—agent_toolsalias expansion, dedup with first-seen order preserved, dedup across an alias and an explicit member of it, and silent-skip of ids not in the registry.listToolMetadata— only registered tools markedenabled, full-registry coverage, andname/descriptionsurfaced for every entry.Tests only, no source changes.
npx vitest run→ 124 passed (10 new);tsc --noEmit -p tsconfig.test.jsonclean.