Skip to content

[eas-cli] Show Organization label and drop "Limited" prefix in new project account picker#3829

Open
davidmokos wants to merge 3 commits into
mainfrom
davidmokos/account-picker-labels
Open

[eas-cli] Show Organization label and drop "Limited" prefix in new project account picker#3829
davidmokos wants to merge 3 commits into
mainfrom
davidmokos/account-picker-labels

Conversation

@davidmokos

@davidmokos davidmokos commented Jun 8, 2026

Copy link
Copy Markdown

Why

The account picker shown by eas new (when choosing which account to own a new project) currently labels accounts as:

  • (Limited - Personal Account) for your own personal account
  • (Limited - Team Account) for accounts owned by another user that you've been added to
  • (no label) for Organization accounts
Screenshot 2026-06-08 at 14 05 28

The "Limited" prefix is confusing - it reads as if some restriction applies to the user, when it's really just describing the kind of account. Organizations are also unlabeled, which makes it hard to tell at a glance what kind of account each row represents (especially when an org and a personal account share a similar name).

The result would look something like this:
Screenshot 2026-06-08 at 16 30 51

How

  • Drops the Limited - prefix.
  • Adds a (Organization) label for Organization-owned accounts (detected via !account.ownerUserActor, matching the existing check in commands/project/init.ts).
  • Adds a short comment noting that (Team) is the legacy setup (a user-owned account with extra collaborators) — new multi-user setups use Organizations.
  • Collapses the three boolean flags + nested ternary into a single suffix derived directly from ownerUserActor, removing an unreachable fallback branch.

Resulting labels:

  • my-personal (Personal) — your own personal account
  • some-team (Team) — legacy user-owned account you were added to
  • some-org (Organization) — Organization account

Test Plan

  • Ran eas new against an account with a mix of personal / team / organization memberships and confirmed each row renders the new label.
  • yarn typecheck and yarn lint pass for eas-cli.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.23%. Comparing base (80baa13) to head (6427637).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commandUtils/new/configs.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3829      +/-   ##
==========================================
+ Coverage   58.13%   58.23%   +0.10%     
==========================================
  Files         917      916       -1     
  Lines       39772    39726      -46     
  Branches     8330     8322       -8     
==========================================
+ Hits        23119    23131      +12     
+ Misses      15211    15162      -49     
+ Partials     1442     1433       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidmokos davidmokos requested a review from mackenco June 8, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant