[eas-cli] Show Organization label and drop "Limited" prefix in new project account picker#3829
Open
davidmokos wants to merge 3 commits into
Open
[eas-cli] Show Organization label and drop "Limited" prefix in new project account picker#3829davidmokos wants to merge 3 commits into
davidmokos wants to merge 3 commits into
Conversation
…oject account picker
|
Subscribed to pull request
Generated by CodeMention |
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
==========================================
+ Coverage 58.13% 58.23% +0.10%
==========================================
Files 917 916 -1
Lines 39772 39726 -46
Branches 8330 8322 -8
==========================================
+ Hits 23119 23131 +12
+ Misses 15211 15162 -49
+ Partials 1442 1433 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The account picker shown by
eas new(when choosing which account to own a new project) currently labels accounts as:(Limited - Personal Account)for your own personal account(Limited - Team Account)for accounts owned by another user that you've been added toThe "Limited" prefix is confusing - it reads as if some restriction applies to the user, when it's really just describing the kind of account. Organizations are also unlabeled, which makes it hard to tell at a glance what kind of account each row represents (especially when an org and a personal account share a similar name).
The result would look something like this:

How
Limited -prefix.(Organization)label for Organization-owned accounts (detected via!account.ownerUserActor, matching the existing check incommands/project/init.ts).(Team)is the legacy setup (a user-owned account with extra collaborators) — new multi-user setups use Organizations.ownerUserActor, removing an unreachable fallback branch.Resulting labels:
my-personal (Personal)— your own personal accountsome-team (Team)— legacy user-owned account you were added tosome-org (Organization)— Organization accountTest Plan
eas newagainst an account with a mix of personal / team / organization memberships and confirmed each row renders the new label.yarn typecheckandyarn lintpass foreas-cli.