[eas-cli] Add 11 new App Store Connect metadata locales#3833
Open
VadimNotJustDev wants to merge 1 commit into
Open
[eas-cli] Add 11 new App Store Connect metadata locales#3833VadimNotJustDev wants to merge 1 commit into
VadimNotJustDev wants to merge 1 commit into
Conversation
Apple expanded App Store Connect localized metadata support to 50 languages, adding Bengali (bn-BD), Gujarati (gu-IN), Kannada (kn-IN), Malayalam (ml-IN), Marathi (mr-IN), Oriya (or-IN), Punjabi (pa-IN), Slovenian (sl-SI), Tamil (ta-IN), Telugu (te-IN), and Urdu (ur-PK). Add these locales to the metadata schema (info and App Clip blocks) and to the iOS submit language list. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Subscribed to pull request
Generated by CodeMention |
Author
|
/changelog-entry chore [eas-cli] Add support for the 11 new App Store Connect metadata locales (Bengali, Gujarati, Kannada, Malayalam, Marathi, Oriya, Punjabi, Slovenian, Tamil, Telugu, Urdu). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Apple expanded App Store Connect localized metadata support to 50 languages, adding 11 new locales (with a focus on India): Bengali, Gujarati, Kannada, Malayalam, Marathi, Oriya, Punjabi, Slovenian, Tamil, Telugu, and Urdu.
EAS CLI didn't know about these locales, so configuring metadata for any of them in
store.config.jsonwas rejected by schema validation, and they weren't selectable when submitting localized metadata. This PR brings EAS CLI in line with the current App Store Connect locale list.How
Added the 11 new locales using Apple's official shortcodes from Managing metadata in your app by using locale shortcodes:
bn-BDpa-INgu-INsl-SIkn-INta-INml-INte-INmr-INur-PKor-INpackages/eas-cli/schema/metadata-0.json— added each locale to both theinfoand App Clip (AppleAppClipInfo) blocks, inserted in theexisting alphabetical-by-language ordering.
packages/eas-cli/src/submit/ios/utils/language.ts— added each locale to the iOS submitLANGUAGESlist. These follow the existing convention (e.g.nl-NL,pt-BR) where the fastlanelocalealready equals the App Store Connect code, so no separateitcLocalemapping is needed.Test Plan
Before this change, configuring metadata for one of the new locales failed schema validation; after, it validates and is accepted.
Before (new locale rejected):
After (new locale accepted):
Also ran:
yarn workspace eas-cli typecheck— passescd packages/eas-cli && yarn test src/submit/ios/utils/__tests__/language-test.ts— passesyarn fmt— applied