[eas-cli] Add --skip-screenshots and --skip-previews flags to metadata commands#3843
Open
TimBroddin wants to merge 1 commit into
Open
[eas-cli] Add --skip-screenshots and --skip-previews flags to metadata commands#3843TimBroddin wants to merge 1 commit into
TimBroddin wants to merge 1 commit into
Conversation
2b95b4b to
2fa740e
Compare
|
Subscribed to pull request
Generated by CodeMention |
2fa740e to
f7444e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
eas metadata:pulldownloads every screenshot and video preview from App Store Connect, andeas metadata:pushsyncs them back. When you only want to manage textual metadata (descriptions, keywords, review info, etc.), downloading/uploading all media assets is slow and unnecessary. This PR adds opt-out flags for both asset types.How
--skip-screenshotsand a--skip-previewsflag to botheas metadata:pullandeas metadata:push.downloadMetadataAsync/uploadMetadataAsynctocreateAppleTasks(), which now filters out theScreenshotsTaskand/orPreviewsTask. Skipping the task entirely also avoids the per-locale screenshot/preview set fetches inprepareAsync.metadata:pull --skip-previewslogs a warning that pushing the generated config without--skip-previewswould delete remote previews. (Screenshots have no such cleanup pass, so mixing the screenshot flag between pull and push is safe.)Test Plan
createAppleTasksfiltering (packages/eas-cli/src/metadata/apple/tasks/__tests__/index.test.ts) and for flag pass-through indownload.test.ts/upload.test.ts.bin/run metadata:pull --helpandbin/run metadata:push --helpshow the new flags.yarn typecheck,yarn lint, andyarn fmt:checkpass.