Skip to content

[build-tools] - bubble validation error for when caches exceed max size#3845

Open
AbbanMustafa wants to merge 3 commits into
mainfrom
mus/cache-validationerr
Open

[build-tools] - bubble validation error for when caches exceed max size#3845
AbbanMustafa wants to merge 3 commits into
mainfrom
mus/cache-validationerr

Conversation

@AbbanMustafa

Copy link
Copy Markdown
Contributor

Why

How

https://github.com/expo/universe/pull/28086

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@AbbanMustafa AbbanMustafa added the no changelog PR that doesn't require a changelog entry label Jun 10, 2026
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.34%. Comparing base (d2ed1fe) to head (8c45fdf).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...kages/build-tools/src/steps/functions/saveCache.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3845      +/-   ##
==========================================
+ Coverage   58.26%   58.34%   +0.09%     
==========================================
  Files         917      917              
  Lines       39827    39942     +115     
  Branches     8350     8412      +62     
==========================================
+ Hits        23200    23302     +102     
- Misses      15193    16545    +1352     
+ Partials     1434       95    -1339     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant