Skip to content

feat: add multiple edgecase for mcp spec#190

Merged
Kinfe123 merged 3 commits into
mainfrom
feat/mcp-spec-edge-cases
May 15, 2026
Merged

feat: add multiple edgecase for mcp spec#190
Kinfe123 merged 3 commits into
mainfrom
feat/mcp-spec-edge-cases

Conversation

@Kinfe123
Copy link
Copy Markdown
Member

@Kinfe123 Kinfe123 commented May 15, 2026

Summary by cubic

Adds robust MCP endpoint discovery with origin, root-domain, and mcp. subdomain fallbacks (handles multi-part public suffixes). Updates docs doctor and the score page to pass when any MCP endpoint works and show clearer, targeted probe details.

  • New Features

    • Added buildDocsMcpEndpointCandidates() with origin, root-domain, and mcp. subdomain fallbacks; supports domains like example.co.uk and example.co.kr.
    • Exported buildDocsMcpEndpointCandidates, DocsMcpEndpointCandidate, and DocsMcpEndpointCandidateOptions.
    • docs doctor --agent now probes declared mcp.publicEndpoints (or mcp.endpoints) from discovery or defaults, plus mcp.<domain>/mcp and mcp.<domain>/.
    • Docs updated to list the new MCP probe targets; tests added for candidate generation.
  • Refactors

    • Hosted MCP check now passes if any candidate succeeds and shows only successful probe details; otherwise shows all with a targeted action listing candidate labels.
    • Agent score page uses buildDocsMcpEndpointCandidates() and the same pass-if-any logic for MCP readiness.
    • OpenAPI route display on the score page respects discovery.openapi.enabled and capabilities; only shows a route when enabled or required.

Written for commit 68adb93. Summary will update on new commits. Review in cubic

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-website Ready Ready Preview, Comment May 15, 2026 3:15pm

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 15, 2026

Open in StackBlitz

@farming-labs/astro

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/astro@190

@farming-labs/astro-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/astro-theme@190

@farming-labs/docs

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/docs@190

@farming-labs/theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/theme@190

@farming-labs/next

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/next@190

@farming-labs/nuxt

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/nuxt@190

@farming-labs/nuxt-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/nuxt-theme@190

@farming-labs/svelte

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/svelte@190

@farming-labs/svelte-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/svelte-theme@190

@farming-labs/tanstack-start

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/tanstack-start@190

commit: 68adb93

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 8 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="skills/farming-labs/cli/SKILL.md">

<violation number="1" location="skills/farming-labs/cli/SKILL.md:452">
P3: Use absolute URLs (including protocol) for the MCP subdomain probe examples. The current values omit `https://`, so they are not valid URLs and do not match the actual generated probe candidates.</violation>
</file>

<file name="packages/docs/src/agent.ts">

<violation number="1" location="packages/docs/src/agent.ts:994">
P2: Registrable-domain fallback is incorrect for unlisted multi-part public suffixes, producing wrong MCP probe hostnames (for example `co.kr` instead of `example.co.kr`).</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Re-trigger cubic

Comment thread packages/docs/src/agent.ts Outdated
Comment thread skills/farming-labs/cli/SKILL.md Outdated
@Kinfe123 Kinfe123 merged commit 8c40182 into main May 15, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant