feat: add multiple edgecase for mcp spec#190
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
@farming-labs/astro
@farming-labs/astro-theme
@farming-labs/docs
@farming-labs/theme
@farming-labs/next
@farming-labs/nuxt
@farming-labs/nuxt-theme
@farming-labs/svelte
@farming-labs/svelte-theme
@farming-labs/tanstack-start
commit: |
Contributor
There was a problem hiding this comment.
2 issues found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="skills/farming-labs/cli/SKILL.md">
<violation number="1" location="skills/farming-labs/cli/SKILL.md:452">
P3: Use absolute URLs (including protocol) for the MCP subdomain probe examples. The current values omit `https://`, so they are not valid URLs and do not match the actual generated probe candidates.</violation>
</file>
<file name="packages/docs/src/agent.ts">
<violation number="1" location="packages/docs/src/agent.ts:994">
P2: Registrable-domain fallback is incorrect for unlisted multi-part public suffixes, producing wrong MCP probe hostnames (for example `co.kr` instead of `example.co.kr`).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds robust MCP endpoint discovery with origin, root-domain, and
mcp.subdomain fallbacks (handles multi-part public suffixes). Updatesdocs doctorand the score page to pass when any MCP endpoint works and show clearer, targeted probe details.New Features
buildDocsMcpEndpointCandidates()with origin, root-domain, andmcp.subdomain fallbacks; supports domains likeexample.co.ukandexample.co.kr.buildDocsMcpEndpointCandidates,DocsMcpEndpointCandidate, andDocsMcpEndpointCandidateOptions.docs doctor --agentnow probes declaredmcp.publicEndpoints(ormcp.endpoints) from discovery or defaults, plusmcp.<domain>/mcpandmcp.<domain>/.Refactors
buildDocsMcpEndpointCandidates()and the same pass-if-any logic for MCP readiness.discovery.openapi.enabledand capabilities; only shows a route when enabled or required.Written for commit 68adb93. Summary will update on new commits. Review in cubic