feature(firestore): added minimum and maximum FieldValue operations#9913
feature(firestore): added minimum and maximum FieldValue operations#9913MarkDuckworth wants to merge 12 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: e3cbb16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces minimum and maximum numeric transforms to Firestore, allowing users to update fields based on numeric comparisons. The changes span the public API, internal transform operations, serialization, and include extensive integration and unit tests. Feedback focuses on correcting typos in the documentation and suggests refactoring duplicated logic for numeric type determination into a shared helper function.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…se/firebase-js-sdk into markduckworth/min-max-field-value
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces minimum and maximum FieldValue operations to Firestore, allowing for server-side numeric comparisons during document updates. The implementation includes new transform operations, updated serialization logic, and comprehensive integration and unit tests. Feedback was provided to rename a variable in a shared helper function to improve clarity, as it currently uses a name specific to one operation type while supporting both.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…se/firebase-js-sdk into markduckworth/min-max-field-value
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@firebase/firestore": patch | |||
There was a problem hiding this comment.
Public API change so should be minor, plus "firebase: minor"
There was a problem hiding this comment.
good catch. thanks
4 participants
Port of googleapis/google-cloud-node#8151