Always send a stack trace in recordError for ER clustering#9930
Always send a stack trace in recordError for ER clustering#9930tonybaroneee wants to merge 1 commit intocrashlytics2from
Conversation
|
There was a problem hiding this comment.
Code Review
This pull request refactors the recordError function to normalize all error inputs into an Error object before logging. This ensures that error.type and error.stack attributes are consistently included in the emitted logs, even when the input is a string or an unknown type. Corresponding unit tests have been updated to reflect these changes. I have no feedback to provide.
5f3c8a9 to
dfdfc40
Compare
andrewbrook
left a comment
There was a problem hiding this comment.
Try to collect the line where the message is thrown, if possible. Otherwise consider sending up some metadata to flag this scenario.
No description provided.