Skip to content

Always send a stack trace in recordError for ER clustering#9930

Open
tonybaroneee wants to merge 1 commit intocrashlytics2from
always-log-stack-trace
Open

Always send a stack trace in recordError for ER clustering#9930
tonybaroneee wants to merge 1 commit intocrashlytics2from
always-log-stack-trace

Conversation

@tonybaroneee
Copy link
Copy Markdown

No description provided.

@tonybaroneee tonybaroneee requested a review from a team as a code owner May 6, 2026 22:03
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

⚠️ No Changeset found

Latest commit: dfdfc40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the recordError function to normalize all error inputs into an Error object before logging. This ensures that error.type and error.stack attributes are consistently included in the emitted logs, even when the input is a string or an unknown type. Corresponding unit tests have been updated to reflect these changes. I have no feedback to provide.

@tonybaroneee tonybaroneee force-pushed the always-log-stack-trace branch from 5f3c8a9 to dfdfc40 Compare May 7, 2026 00:36
Copy link
Copy Markdown

@andrewbrook andrewbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to collect the line where the message is thrown, if possible. Otherwise consider sending up some metadata to flag this scenario.

@tonybaroneee tonybaroneee removed request for a team, MaesterChestnut and rebehe May 7, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants