Conversation
- Fix emulator crash when using uuidv4() on operations (#9852) - Support for `_Data` input types as operation variables, enabling batch mutations. - The `@allow` directive on variable definitions to restrict fields and max item counts for `_Data` variables. - Dart codegen doesn't handle nullable BigInt.
fredzqm
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase Data Connect local toolkit to version 3.4.9, which includes bug fixes for the emulator and Dart codegen, as well as new support for _Data input types and the @Allow directive. Review feedback highlights an inconsistency where the expectedSize for the Linux platform was not updated alongside the version and checksums, which could lead to integrity check failures. Additionally, it is recommended to rephrase a changelog entry to describe the action taken rather than just the problem encountered.
I am having trouble creating individual review comments. Click here to see my feedback.
src/emulator/downloadableEmulatorInfo.json (81)
The expectedSize for the Linux platform (line 82) remains unchanged from version 3.4.7, while the version and checksums have been updated. In contrast, the sizes for all other platforms (darwin, darwin_arm64, win32) have been updated in this PR. This inconsistency strongly suggests that the expectedSize for the Linux binary was overlooked, which will likely cause download or integrity check failures for Linux users.
CHANGELOG.md (5)
This changelog entry describes the problem rather than the fix. To maintain consistency with the other entries (such as the one on line 2) and provide clearer information to users, it should be rephrased to describe the action taken.
- Fix an issue where Dart codegen did not handle nullable BigInt.
References
- For any user-facing change (new features, bug fixes, deprecations), add a corresponding entry to CHANGELOG.md. (link)
2 participants
No description provided.