Integrate upstream package variables into Quickstart#179
Open
fivetran-jamie wants to merge 4 commits into
Open
Integrate upstream package variables into Quickstart#179fivetran-jamie wants to merge 4 commits into
fivetran-jamie wants to merge 4 commits into
Conversation
fivetran-jamie
changed the title
fivetran-avinash
left a comment
fivetran-avinash
left a comment
Contributor
There was a problem hiding this comment.
@fivetran-jamie Few comments before approval!
Comment on lines
+302
to
+309
| pinterest__campaign_report_passthrough_metrics: | ||
| type: dictionary | ||
| description: "Additional `CAMPAIGN_REPORT` columns to include in `pinterest_ads__campaign_report`" | ||
| display_name: "Pinterest Ads: Additional Campaign Report Metrics" | ||
| pinterest__keyword_report_passthrough_metrics: | ||
| type: dictionary | ||
| description: "Additional `KEYWORD_REPORT` columns to include in `pinterest_ads__keyword_report`" | ||
| display_name: "Pinterest Ads: Additional Keyword Report Metrics" |
Contributor
There was a problem hiding this comment.
For future reference (doesn't need to be fixed now): the quickstart.yml descriptions are correct here but incorrect in dbt_pinterest.
Contributor
Author
There was a problem hiding this comment.
Yeah I noticed a few issues -- will make a ticket after this to update the packages
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
fivetran-avinash
left a comment
fivetran-avinash
left a comment
Contributor
There was a problem hiding this comment.
@fivetran-jamie approved for pre-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog