Feature/submission response - #203
Merged
Merged
Conversation
fivetran-jamie
commented
Jun 23, 2026
| {"name": "_fivetran_synced", "datatype": dbt.type_timestamp()}, | ||
| {"name": "_fivetran_deleted", "datatype": dbt.type_boolean()}, | ||
| {"name": "guid", "datatype": dbt.type_bigint()}, | ||
| {"name": "guid", "datatype": dbt.type_string()}, |
Collaborator
Author
There was a problem hiding this comment.
Seeing this as a string in our data
fivetran-jamie
commented
Jun 23, 2026
Comment on lines
+6
to
+8
| {"name": "form_id", "datatype": dbt.type_string()}, | ||
| {"name": "contact_id", "datatype": dbt.type_bigint()}, | ||
| {"name": "conversion_id", "datatype": dbt.type_bigint()}, | ||
| {"name": "conversion_id", "datatype": dbt.type_string()}, |
Collaborator
Author
There was a problem hiding this comment.
Seeing form_id and conversion_id as strings in our data
fivetran-jamie
marked this pull request as ready for review
June 23, 2026 18:17
Collaborator
Author
|
will resolve merge conflicts after approval |
fivetran-joemarkiewicz
self-requested a review
June 24, 2026 15:09
fivetran-joemarkiewicz
approved these changes
Jun 24, 2026
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
Contributor
There was a problem hiding this comment.
A few comments to address before merging. Nothing blocking from approval.
Comment on lines
+3
to
+9
| {{ | ||
| hubspot.hubspot_union_connections( | ||
| connection_dictionary='hubspot_sources', | ||
| single_source_name='hubspot', | ||
| single_table_name='submission_response' | ||
| ) | ||
| }} |
Contributor
There was a problem hiding this comment.
This needs to use fivetran_utils.union_connections
| staging_columns=get_submission_response_columns() | ||
| ) | ||
| }} | ||
| {{ hubspot.apply_source_relation() }} |
Contributor
There was a problem hiding this comment.
Update this to use fivetran_utils version
| ## Schema Change | ||
| **8 new models • 0 possible breaking changes** | ||
| ## Schema/Data Change | ||
| **2 new models • 0 possible breaking changes• 6 total changes** |
Contributor
There was a problem hiding this comment.
Suggested change
| **2 new models • 0 possible breaking changes• 6 total changes** | |
| **2 new models • 0 possible breaking changes • 6 total changes** |
Collaborator
Author
There was a problem hiding this comment.
Adjusting directly
Comment on lines
+10
to
+11
| | `hubspot__contacts` | New fields | | `calculated_first_conversion_fields_responded_to`<br>`calculated_most_recent_conversion_fields_responded_to` | Comma-separated list of fields submitted during the contact's first and most recent form conversions. | | ||
| | `hubspot__contacts` | New fields | | `calculated_first_conversion_total_responses`<br>`calculated_most_recent_conversion_total_responses` | Number of fields submitted during the contact's first and most recent form conversions. | |
Contributor
There was a problem hiding this comment.
These are nearly identical. Any way we can consolidate into one row?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
submission_responsetable into contact form metricsSubmission Checklist
Changelog