Add product DFTs to gr_dft; make acb_dft a thin wrapper#2774
Open
fredrik-johansson wants to merge 2 commits into
Open
Add product DFTs to gr_dft; make acb_dft a thin wrapper#2774fredrik-johansson wants to merge 2 commits into
gr_dft; make acb_dft a thin wrapper#2774fredrik-johansson wants to merge 2 commits into
Conversation
… and remove obsolete algorithm functions
Contributor
|
This looks great! There were no problems wrapping it in Julia (though it needs some polishing to make it actually use friendly) and the performance seems to be very good! I made a quick comparison to GenericaFFT.jl and at 53 bits of precision it is about 50 times slower than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We change
acb_dftto a thin wrapper aroundgr_dftfor the main functions, removing obsolete algorithm functions. This makesacb_dftsignificantly faster (and probably more precise). The only significant functionality that was missing,acb_dft_prod, is also ported togr_dft, and with itacb_dirichlet_dft.@edgarcosta Would be great if you could test accuracy/speed of the new DFT code for the applications where you've been using it.
Also @Joel-Dahne maybe you are able to test this.
As a sanity check, this immediately speeds up vector evaluation of Dirichlet L-functions.
Old:
New:
Enclosures are also tighter. Old:
New: