Add candidate-patch rollout hook to reward.py (#2a)#2
Open
flo7up wants to merge 1 commit into
Open
Conversation
reward.py previously built the image from the static base snapshot with no way to supply a candidate fix, so an unmodified taskpack scored 0.0 by construction and there was no supported path to 1.0 — i.e. no way to actually grade an agent's attempt. This adds that path. - reward.py (generated template): `--patch <diff>` copies repo/ to a throwaway temp dir, applies the patch with `git apply` (works without .git), builds the image from the patched copy, runs the tests, and cleans up. The base snapshot is never mutated. A non-applying patch -> 0.0 with a clear error, reported before the docker step. Container engine is configurable via FORGE_DOCKER_BIN (e.g. podman). - reward_runner.run_reward_script / `forge reward`: add `--patch` passthrough (resolved to an absolute path before invoking the script). - tests/test_reward_rollout.py: run the generated script as a subprocess with a bogus FORGE_DOCKER_BIN to prove staging behavior without a container engine — good patch applies and reaches the docker check (base left unmodified), bad patch is rejected first, missing patch reported, no-patch path preserved, and the wrapper passes --patch through. Plus a compile() check on the template. 84 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@-