Skip to content

[camera_avfoundation] Move camera_avfoundation to Darwin#11847

Open
Mairramer wants to merge 8 commits into
flutter:mainfrom
Mairramer:camera-avfoundation-step1-darwin-rename
Open

[camera_avfoundation] Move camera_avfoundation to Darwin#11847
Mairramer wants to merge 8 commits into
flutter:mainfrom
Mairramer:camera-avfoundation-step1-darwin-rename

Conversation

@Mairramer

Copy link
Copy Markdown
Contributor

This PR moves the camera_avfoundation plugin implementation to Darwin, aiming to consolidate the shared AVFoundation codebase for both iOS and macOS platforms.

Part of flutter/flutter#41708

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@Mairramer
Mairramer marked this pull request as ready for review June 5, 2026 16:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves the camera_avfoundation package source files to a shared Darwin directory. It updates the Pigeon Swift output path to the new darwin directory, adds sharedDarwinSource: true to the iOS plugin configuration in pubspec.yaml, and documents the change in the changelog. There are no review comments, and I have no feedback to provide.

@Mairramer

Copy link
Copy Markdown
Contributor Author

Maybe we should move the tests as well?

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should move the tests as well?

Yes, native unit tests that would be shared should move to darwin/Tests/, and the Xcode project updated to reference the files there, as with other plugins in the repo that use shared source.

Comment thread packages/camera/camera_avfoundation/CHANGELOG.md Outdated
@stuartmorgan-g stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jun 9, 2026
@Mairramer

Copy link
Copy Markdown
Contributor Author

Maybe we should move the tests as well?

Yes, native unit tests that would be shared should move to darwin/Tests/, and the Xcode project updated to reference the files there, as with other plugins in the repo that use shared source.

Done.

Comment thread packages/camera/camera_avfoundation/example/ios/RunnerTests/.gitkeep Outdated
@stuartmorgan-g stuartmorgan-g added CICD Run CI/CD override: no versioning needed Override the check requiring version bumps for most changes labels Jun 17, 2026

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 22, 2026
@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Version/CHANGELOG override: The only failure mode for clients here should be a complete failure to build if it were incorrect, which CI would catch, so we can skip releasing this.

@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Jun 22, 2026
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 7, 2026
@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Jul 7, 2026
@stuartmorgan-g
stuartmorgan-g requested a review from LouiseHsu July 7, 2026 15:27
@stuartmorgan-g stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Jul 14, 2026
@okorohelijah

Copy link
Copy Markdown
Contributor

from triage: is this still on your radar @LouiseHsu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera platform-ios platform-macos triage-ios Should be looked at in iOS triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants