feat(a380x/fws): hide departure change checklist depending on flightphase#10551
Open
BravoMike99 wants to merge 10 commits intoflybywiresim:masterfrom
Open
feat(a380x/fws): hide departure change checklist depending on flightphase#10551BravoMike99 wants to merge 10 commits intoflybywiresim:masterfrom
BravoMike99 wants to merge 10 commits intoflybywiresim:masterfrom
Conversation
github-project-automation
bot
moved this to 🟡 Code Review: Ready for Review
in Quality Assurance
BravoMike99
force-pushed
the
no-departure-change
branch
from
ff8c729 to
d71c364
Compare
Jonny23787
reviewed
Apr 9, 2026
| public readonly predWSOn = Subject.create(false); | ||
|
|
||
| public readonly seatBelt = Subject.create(0); | ||
| private readonly seatBetlSignRegisteredSimvar = RegisteredSimVar.createBoolean('A:CABIN SEATBELTS ALERT SWITCH'); |
flogross89
requested changes
Apr 9, 2026
| this.checklistState.setValue(this.checklistId.get(), newState); | ||
| this.showChecklistRequested.set(false); | ||
| if (id === DEPARTURE_CHANGE_NORMAL_CHECKLIST_ID) { | ||
| // If departure change checklist is completed.. reset it. |
Contributor
There was a problem hiding this comment.
Don't quite get that line, could you briefly explain? Doesn't that mean that the departure change checklist is never completed, because it resets the second you do so?
Contributor
Author
There was a problem hiding this comment.
Yeah, so you have to complete all the items again.
| for (let id = fromId === null ? 0 : fromId + 1; id < ids.length; id++) { | ||
| this.fws.manualCheckListReset.set(fromId !== undefined); | ||
|
|
||
| // Show Departure change again if, checklist automatically reset or a manual checklist reset occurs on a subsequent CL. |
Contributor
There was a problem hiding this comment.
... occurs on an earlier (not subsequent) CL, right?
| if (departureChangeIdx !== -1) { | ||
| overviewState.itemsToShow[departureChangeIdx] = !value; | ||
| this.checklistState.setValue(CHECKLIST_OVERVIEW_ID, overviewState); | ||
| // If we are hiding the departure change implicitly transmit to event bus so change is recieved in the EWD. |
Contributor
There was a problem hiding this comment.
Tiny typo : ... recieved ...
Contributor
Author
There was a problem hiding this comment.
Oops, this and the above should be fixed.
github-project-automation
bot
moved this from 🟡 Code Review: Ready for Review
to 🔴 Code Review: In progress
in Quality Assurance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10093
Summary of Changes
Hides departure change checklist from the ECL depending on flightphase.
Cleans up some of the FWS code
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): bruno_pt99
Testing instructions
Spawn on the runway or do pref-light as per usual and check that the departure change checklist is visible with a blue title.
Set takeoff thrust/takeoff, check that the departure change checklist is no longer visible on the EWD. If you spawned on the runway wait a bit for the FWS to initialize.
Reset a checklist of your choice before departure change (lineup, after start, cockpti prep). After doing so the departure change should remain hidden provided engines are in takeoff power.
Set the engines back to idle if still on the ground or land and repeat the previous process. Departure change checklist should appear again.
Complete the departure change checklist and verify it is reset automatically upon completion (title remains blue and all items are no longer checked when accessed again).
Regression testing:
Check that all normal checklists work as per usual.
Check that seatbelts & no mobile memos work correctly.
Check that takeoff and landing items work correctly on the EWD
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.