-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(gsx): Changes to support new Loader Behavior, Handlers and Service Cancellation #10560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Fragtality
wants to merge
6
commits into
flybywiresim:master
Choose a base branch
from
Fragtality:gsx-changes-new-features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
daa56cb
fix(gsx): Changes to support new Loader Behavior, Handlers and Servic…
Fragtality 0a7b52d
Fixed Changelog
Fragtality 7a87a42
Fixed XML Chock Condition
Fragtality d3cefc6
Changed GSX Power Sync to use connected State instead of Service State
Fragtality 00825bb
Reduced overrides in GSX Handler (ofc there are caveats) / Reworked G…
Fragtality 2afefb7
Merge branch 'master' into gsx-changes-new-features
Fragtality File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...c/base/flybywire-aircraft-a320-neo/SimObjects/AirPlanes/FlyByWire_A320_NEO/gsx_handler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| friendlyName = "FlyByWire A32NX Handler" | ||
| # Ensuring that Chocks and Brakes Tests are not overriden by an User-Profile | ||
| chocksTest = "(L:A32NX_PARK_BRAKE_LEVER_POS,number) (L:A32NX_GND_EQP_IS_VISIBLE,number) ||" | ||
| brakesTest = "(L:A32NX_PARK_BRAKE_LEVER_POS,number)" | ||
| fuelSync = LVariable("A32NX_GSX_FUEL_SYNC_ENABLED") | ||
|
|
||
| def onJetwayConnected(self): | ||
| pass | ||
|
|
||
| def onJetwayDisconnected(self): | ||
| pass | ||
|
|
||
| def setExtPowerAvail(self): | ||
| pass | ||
|
|
||
| def customTruckRequestedMessage(self): | ||
| if fuelSync.getValue() != 0: | ||
| return "Fuel Truck requested - load OFP/set planned Fuel in FlyPad" | ||
| else: | ||
| return self._super_customTruckRequestedMessage() | ||
|
|
||
| def customRefuelMessage(self): | ||
| if fuelSync.getValue() != 0: | ||
| return "GSX Refuel in Progress" | ||
| else: | ||
| return self._super_customRefuelMessage() | ||
|
|
||
| def customTruckInPositionMessage(self): | ||
| if fuelSync.getValue() != 0: | ||
| return "Fuel Truck in Position - Refuel starts automatically" | ||
| else: | ||
| return self._super_customTruckInPositionMessage() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...c/base/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/gsx_handler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| friendlyName = "FlyByWire A380X Handler" | ||
| # Ensuring that Chocks and Brakes Tests are not overriden by an User-Profile | ||
| chocksTest = "(L:A32NX_PARK_BRAKE_LEVER_POS,number) (L:A32NX_GND_EQP_IS_VISIBLE,number) ||" | ||
| brakesTest = "(L:A32NX_PARK_BRAKE_LEVER_POS,number)" | ||
| fuelSync = LVariable("A32NX_GSX_FUEL_SYNC_ENABLED") | ||
|
|
||
| def onJetwayConnected(self): | ||
| pass | ||
|
|
||
| def onJetwayDisconnected(self): | ||
| pass | ||
|
|
||
| def setExtPowerAvail(self): | ||
| pass | ||
|
|
||
| def customTruckRequestedMessage(self): | ||
| if fuelSync.getValue() != 0: | ||
| return "Fuel Truck requested - set planned Fuel in FlyPad" | ||
| else: | ||
| return self._super_customTruckRequestedMessage() | ||
|
|
||
| def customRefuelMessage(self): | ||
| if fuelSync.getValue() != 0: | ||
| return "GSX Refuel in Progress" | ||
| else: | ||
| return self._super_customRefuelMessage() | ||
|
|
||
| def customTruckInPositionMessage(self): | ||
| if fuelSync.getValue() != 0: | ||
| return "Fuel Truck in Position - Refuel starts automatically" | ||
| else: | ||
| return self._super_customTruckInPositionMessage() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the
pbe capitalised?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just thought it should be for camel case and consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't name it ... so maybe? 😅