Skip to content

fix buffer overflow on all emphasis flags set #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitaut merged 2 commits into from
Jul 20, 2025
Merged

fix buffer overflow on all emphasis flags set #4498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b80433
fix buffer overflow on all emphasis flags set
dominicpoeschko Jul 15, 2025
7cbbd5d
add test case for all emphasis flags set
dominicpoeschko Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/fmt/color.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ template <typename Char> struct ansi_color_escape {

private:
static constexpr size_t num_emphases = 8;
Char buffer[7u + 3u * num_emphases + 1u];
Char buffer[7u + 4u * num_emphases + 1u];

static FMT_CONSTEXPR void to_esc(uint8_t c, Char* out,
char delimiter) noexcept {
Expand Down