add support for positional arguments as width and precision specifiers#4643
Merged
vitaut merged 2 commits intofmtlib:masterfrom Jan 5, 2026
Merged
add support for positional arguments as width and precision specifiers#4643vitaut merged 2 commits intofmtlib:masterfrom
vitaut merged 2 commits intofmtlib:masterfrom
Conversation
… floating-point formats too
vitaut
requested changes
Jan 2, 2026
Contributor
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
Thanks for the PR! Overall looks good but please fix CI failures.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit adds support for using positional arguments as width and precision specifiers in
printf.hformat strings (including as width/precision for float formats) as pointed out by issue #4636.Tests have been added to
printf-test.cc