fix(forge): preserve debug traces when setUp reverts#14390
Open
IrshadKohl51 wants to merge 2 commits intofoundry-rs:masterfrom
Open
fix(forge): preserve debug traces when setUp reverts#14390IrshadKohl51 wants to merge 2 commits intofoundry-rs:masterfrom
IrshadKohl51 wants to merge 2 commits intofoundry-rs:masterfrom
Conversation
figtracer
reviewed
Apr 23, 2026
Collaborator
@figtracer follow-up ? Is this g2g ? |
figtracer
approved these changes
Apr 23, 2026
Collaborator
would like to get another approval from @zerosnacks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
forge test --debugcurrently only feedsExecutiontraces into the debugger.When
setUp()reverts, there is no execution trace, so debugger startup fails withError: debug arena is emptyand--dumpcannot be used in this failure path (see #10322).Solution
forge test --debug, preferExecutiontraces, but fall back to availableSetup/Deploymenttraces when execution traces are empty.test_debug_with_dump_setup_revertto verify:--debug --dumpcompletes whensetUp()reverts,debug arena is emptyis not emitted,PR Checklist