Fix TCP stack – vFPGA routing and add TCP performance examples - #149
Open
adpp00 wants to merge 2 commits into
Open
Fix TCP stack – vFPGA routing and add TCP performance examples#149adpp00 wants to merge 2 commits into
adpp00 wants to merge 2 commits into
Conversation
bo3z
requested changes
Nov 25, 2025
bo3z
left a comment
bo3z
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for bringing back the TCP/IP stack. The code looks very good. I've finished the review and there are some minor comments that cover corner cases and make sure the TCP/IP stack follows the same design principles as other components in Coyote. I can look into addressing these.
| logic [N_REGIONS-1 : 0] s_axis_tx_last; | ||
| logic [AXI_DATA_BITS-1 : 0] s_axis_tx_data [N_REGIONS]; | ||
|
|
||
| for(genvar i = 0; i < N_REGIONS; i++) begin |
Collaborator
There was a problem hiding this comment.
As above, we should check if these arrays will synthesize correctly in a genvar block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes:
tcp_perf)Type of change
Tests & Results
tcp_perfChecklist