Refactored SSE watcher to manage multiple event sources#534
Merged
Conversation
Matthbo
reviewed
Jun 2, 2026
Member
Matthbo
left a comment
Matthbo
left a comment
There was a problem hiding this comment.
Wow that's easy
The only thing that could be improved is to keep the watcher open as long as the project is open. Now it seems to close on the configuration overview page and reopen once navigated back to either the editor or studio page.
Is this possible?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before every component was calling useSseWatcher with the same URL would open its own EventSource connection. When the component unmounted, it would close it immediately and this continued.
Now if two components watch the same URL, they reuse the same EventSource. Each registers its own handler on that shared connection. The connection only closes when the last subscriber unmounts